-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FOGL-7706: fetch plugins using notification service ip and port #1473
base: develop
Are you sure you want to change the base?
Conversation
FOGL-7706: fetch plugins using notification service ip and port
Compilation fix
Unit test fixes
@ashwinscale @ashish-jabble please test and approve. This fix should be added to new release as it is requested by new customers |
@MarkRiddoch is this safe to consider for release at this point?
|
@praveen-garg any update in this? |
@pintomax I'm not sure how the things change with this. Each endpoint def in Here get_plugin_data is added which does the same.
How did you test this? |
if 'rules' not in rule_plugins: | ||
resp['rules'] = rule_plugins | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? Are we not sure about the response object of rule_plugins from notification service?
if 'delivery' not in delivery_plugins: | ||
resp['delivery'] = delivery_plugins | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? Are we not sure about the response object of rule_plugins from notification service?
FOGL-7706: fetch plugins using notification service ip and port