This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Refactor: Unix domain sockets for abci communication #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Switches from TCP to unix sockets for faster communication between application and consensus. The ABCI client we were using before was synchronous and blocking so created async non blocking client instead.
We dont want rpc requests blocking the ABCI query client, and we want to keep the client connection alive for fast innerprocess querys so ive also added all rpc querys will spawn a new task with its own client and the query client we keep alive will only be used for innerproccess querys
What
Checklist