Frame of reference UID fix #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I tested it successfully with my local ShUp. Might be worth testing on the server too. Cheers, Michael |
michaelkain
requested review from
jcomedouteau
and removed request for
LaurentPV
...mization/src/main/java/org/shanoir/anonymization/anonymization/AnonymizationServiceImpl.java
Outdated
Show resolved
Hide resolved
|
Otherwise, everything is working fine for server import. |
LaurentPV
reviewed
Nov 18, 2024
...mization/src/main/java/org/shanoir/anonymization/anonymization/AnonymizationServiceImpl.java
Outdated
Show resolved
Hide resolved
michaelkain
commented
Nov 28, 2024
...mization/src/main/java/org/shanoir/anonymization/anonymization/AnonymizationServiceImpl.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is the follow up of an issue raised by GE.
With the fix respect the DICOM structure concerning the frameOfReferenceUID, as given in the original DICOM.