-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shanoir-issue#2482: call subject delete in preclinical and datasets at the same time #2493
Open
pierrehenri-dauvergne
wants to merge
19
commits into
fli-iam:develop
Choose a base branch
from
pierrehenri-dauvergne:shanoir-issue#2482
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
shanoir-issue#2482: call subject delete in preclinical and datasets at the same time #2493
pierrehenri-dauvergne
wants to merge
19
commits into
fli-iam:develop
from
pierrehenri-dauvergne:shanoir-issue#2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auvergne/shanoir-ng into shanoir-issue#2482
pierrehenri-dauvergne
added
subject
REVIEWABLE
Has to be reviewed
and removed
WorkInProgress
labels
Nov 13, 2024
...oir-ng-datasets/src/main/java/org/shanoir/ng/configuration/amqp/RabbitMQDatasetsService.java
Outdated
Show resolved
Hide resolved
shanoir-ng-studies/src/main/java/org/shanoir/ng/subject/controler/SubjectApiController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test:
Create new study
Create new subject and add it to the new study
Open study details > Edit > Subject tab > Remove subject > Save study
Subject should be removed from the study without error
If the subject do not belong to any other study, it should be deleted along with all of its data (examinations, acquisitions, datasets)
Also try with a subject that has examinations and a preclinical subject