Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shanoir-issue#2471: add sorting_index to search #2515

Merged
merged 6 commits into from
Dec 2, 2024
Merged

shanoir-issue#2471: add sorting_index to search #2515

merged 6 commits into from
Dec 2, 2024

Conversation

pierrehenri-dauvergne
Copy link
Collaborator

@pierrehenri-dauvergne pierrehenri-dauvergne commented Nov 25, 2024 •
edited
Loading

How to test:
Open solr
Look for the "Sorting index" column
It's the value "sorting index" of the acquisition of the dataset

image

@pierrehenri-dauvergne pierrehenri-dauvergne linked an issue Nov 25, 2024 that may be closed by this pull request
Solr search: add seriesNumber (sorting_index) to search #2471
Closed
@pierrehenri-dauvergne pierrehenri-dauvergne self-assigned this Nov 25, 2024
@michaelkain
Copy link
Contributor

Hi @DuckflipXYZ, I think it would be great, if you could review and test this PR of Pierre-Henri please?

@pierrehenri-dauvergne pierrehenri-dauvergne added solr Solr search REVIEWABLE Has to be reviewed and removed WorkInProgress labels Nov 26, 2024
@pierrehenri-dauvergne
Copy link
Collaborator Author

Tested locally and on neurinfo-qualif : OK on both but on qualif, need to run those lines:

dk exec neurinfo-qualif-solr rm -rf /var/solr/data
dk stop neurinfo-qualif-nginx neurinfo-qualif-nifti-conversion neurinfo-qualif-datasets neurinfo-qualif-solr
dk start neurinfo-qualif-nginx neurinfo-qualif-nifti-conversion neurinfo-qualif-datasets neurinfo-qualif-solr

Then login as administrator and run "index to solr"

DuckflipXYZ
DuckflipXYZ approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@DuckflipXYZ DuckflipXYZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Concerning solr re-indexation which needs to be done for remote Shanoir instance, please refer to that issue : #1741. Do not forget to run commands below when deploying this PR in qualif/prod :

dk exec neurinfo-qualif-solr rm -rf /var/solr/data
dk stop neurinfo-qualif-nginx neurinfo-qualif-nifti-conversion neurinfo-qualif-datasets neurinfo-qualif-solr
dk start neurinfo-qualif-nginx neurinfo-qualif-nifti-conversion neurinfo-qualif-datasets neurinfo-qualif-solr
Then login as administrator and run "index to solr"

@michaelkain michaelkain merged commit e6f462d into fli-iam:develop Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuckflipXYZ DuckflipXYZ DuckflipXYZ approved these changes

Assignees

@DuckflipXYZ DuckflipXYZ

Labels
REVIEWABLE Has to be reviewed solr Solr search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solr search: add seriesNumber (sorting_index) to search
3 participants
@pierrehenri-dauvergne @michaelkain @DuckflipXYZ