-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2502 : mass nifti deletion update #2534
Open
DuckflipXYZ
wants to merge
8
commits into
fli-iam:develop
Choose a base branch
from
DuckflipXYZ:2502
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+77
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do it aynchroneously + event to follow - Use a Set<> to avoid multiple delete
- add lazy initialisation
- Manage progress + display in front
- remove dataset name
DuckflipXYZ
force-pushed
the
2502
branch
2 times, most recently
from
December 6, 2024 16:54
7e6886e
to
1600cd8
Compare
Tested in qualif with 3 study in a raw (ids : 20, 21, 32, 32 has 2T of nifti), no issue of server memory. Close this PR opened by Jean-Come when merging : #2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking over Jean-Come works. Some known issues :
1 - PH :
Tested on qualif-ofsep with studyId = 20:
First time I executed the request on swagger, nothing happened
Second time, I got this error:
Whenever I refresh the page (ctrl + F5), I see the job starting over, deleting niftis then stop as the error above is met
Also tested with studyId = 21 (only one query this time) and the same thing happened
2 - PH :
Tested on ofsep-qualif:
Sent the request from swagger to delete niftis
It took something like 4 minutes until I saw the job start, but I sent that request for a study with more than 1Tb of niftis
Once the job finished, I wanted to check if the storage volume was updated but I kept having issues in ms-studies:
Then in ms-users:
And:
I then redeployed, tested on studies with less niftis and it worked nicely.
Then I tried again on the study with 1Tb of nifti, the job stopped at 79% and ms-users threw:
I guess this is because of the duration of the request or something along those lines
Splitting transaction, currently testing