Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shanoir-issue#2658: delete dataset #2668

Merged
merged 11 commits into from
Feb 27, 2025

Conversation

pierrehenri-dauvergne
Copy link
Collaborator

@pierrehenri-dauvergne pierrehenri-dauvergne commented Feb 24, 2025

[Don't pay attention to my local branch name, I push on the wrong branch]
How to test:
Import a big dataset (the one with id 1334910 on ofsep-qualif is quite big)
Open its details
Delete it

There is a task starting to show its progress. It's now done asynchronously

@pierrehenri-dauvergne pierrehenri-dauvergne changed the title shanoir-issue#2660: datasetacquisition mapper shanoir-issue#2658: delete dataset Feb 25, 2025
@pierrehenri-dauvergne pierrehenri-dauvergne linked an issue Feb 25, 2025 that may be closed by this pull request
@michaelkain
Copy link
Contributor

Hi @pierrehenri-dauvergne, I hope you are doing fine.
I realized something important this morning, that is why we should bring this PR in prod with the next release.
ms-datasets is still on OSIV=true, what means one database connection is held and blocked, until all path of one
dataset are send to the pacs, what is very, very bad in terms of resource usage. With @async the connection
should directly go back into the pool, and we delete then from the PACS in another thread. With kind regards,
Michael

@michaelkain
Copy link
Contributor

Hi @pierrehenri-dauvergne,
please call deleteDatasetFromDiskAndPacs(List of DatasetFile) to avoid requiring a database connection in the new thread.
Thank you!

Copy link
Contributor

@michaelkain michaelkain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve by code review, we wait for the PR-Pitch before merging

Copy link
Contributor

@michaelkain michaelkain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by PR-Pitch from 27.02.2025 with Alex, Laurent, Pierre-Henri, Julien, Michael

@michaelkain michaelkain merged commit 91dbc32 into fli-iam:develop Feb 27, 2025
1 check passed
@michaelkain
Copy link
Contributor

2025-02-27 17:00:00,014 INFO [org.dcm4chee.arc.iocm.rs.DeleteRejected] (default task-9) Process DELETE /dcm4chee-arc/reject/113001%5EDCM from [email protected]
2025-02-27 17:00:16,209 INFO [org.dcm4chee.arc.ian.scu.IANScheduler] (EE-ManagedScheduledExecutorService-default-Thread-2) start IANScheduler.execute()
2025-02-27 17:00:16,210 INFO [org.dcm4chee.arc.ian.scu.IANScheduler] (EE-ManagedScheduledExecutorService-default-Thread-2) finished IANScheduler.execute()
2025-02-27 17:00:25,573 INFO [org.dcm4chee.arc.iocm.rs.DeleteRejected] (default task-9) Deleted 13019 instances permanently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deleteDatasets: not working for big dataset
2 participants