Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven build test correction #2671

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

DuckflipXYZ
Copy link
Collaborator

@DuckflipXYZ DuckflipXYZ commented Feb 25, 2025

Hello !

Core fixes are :

  • The creation of a RabbitTemplate configuration. It should be auto-configured by Spring, but for a mysterious reason it's not, so instead we configure it manually with a @config @componentscan class.
  • The addition of a @lazy tag, that breaks a circular dependency which is (it starts with Bids in the cases that I experimented, but it can happens in other way I guess ...):
    --> BidsAPIController --> BIDSServiceImpl --> ExaminationServiceImpl --> StudyInstanceUIDHandler -> ExaminationServiceImpl --> ...

Rest of modified code was not used anymore, so removing them save resources. Ah, and my IDE says that @MockBean is deprecated and from what I see, @MockitoBean is the standard replacement.

@DuckflipXYZ DuckflipXYZ changed the title Test correction* Test correction Feb 25, 2025
@DuckflipXYZ DuckflipXYZ added the REVIEWABLE Has to be reviewed label Feb 25, 2025
@michaelkain
Copy link
Contributor

Hi @DuckflipXYZ, thank you for this PR.
To be honest, I do not know, what the background and the goal is?
Please explain in the weekly. Thank you, Michael

@DuckflipXYZ
Copy link
Collaborator Author

DuckflipXYZ commented Feb 26, 2025

The point is to resolve issues which can occur at maven build step. For example, merge this to the PR #2653 should correct the maven build check made on github. By talking with PH, we agreed that those issues are experimented kinda often, so a global fix seems usefull

@DuckflipXYZ DuckflipXYZ changed the title Test correction Maven build test correction Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REVIEWABLE Has to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants