Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export additional types #298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ericallam
Copy link

We want to give users the ability to add custom transformers, and for that to work nicely with typescript we need these types. I tried to do export type but prettier threw an error (see prettier/prettier-vscode#2558), so I just exported them as values instead.

Copy link
Collaborator

@Skn0tt Skn0tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These types are implementation details. Could you elaborate on your usecase? Maybe we can find a better solution using some TypeScript tricks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants