Order independent array diff #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops - didn't mean to open it against your repo (wanted to put it into my forked master :D) |
|
It's very useful feature. Can this be in main package? |
|
Sure! |
|
Ah ok I'll work on the conflicts on Monday. |
|
So yes and no - It will be able to determine if there is a difference between two unordered objects/arrays, but the output of the diff is particularly smart or useful since the sorting doesn't always align "like" terms. There would probably have to be a fair amount of work to make the output a sensible diff. |
|
I'm checking it out; if it does what it says, I agree. |
|
Wrong branch - I'll reopen |
|
Would be very useful to have this feature, exactly facing the case #100 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.