Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Door State MQTT #963

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

maximeallanic
Copy link

To solve this issue:
#962

Copy link
Owner

@flobz flobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for you contribution, please look at my feedbacks.

psa_car_controller/psa/RemoteClient.py Outdated Show resolved Hide resolved
@@ -51,6 +51,18 @@ def get_vehicle_info(vin):
)
return response

@app.route('/get_doors_state/<string:vin>')
def get_doors_state(vin):
doors_state = APP.myp.remote_client.doors_state.get(vin)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you document possible value for door_state ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this?

/**
    @return {'doors_opening_state': number[]; 'doors_locking_state': number}
*/

Have you an example of documentation? And where i set? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants