-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Door State MQTT #963
base: master
Are you sure you want to change the base?
Add Door State MQTT #963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for you contribution, please look at my feedbacks.
@@ -51,6 +51,18 @@ def get_vehicle_info(vin): | |||
) | |||
return response | |||
|
|||
@app.route('/get_doors_state/<string:vin>') | |||
def get_doors_state(vin): | |||
doors_state = APP.myp.remote_client.doors_state.get(vin) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you document possible value for door_state ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this?
/**
@return {'doors_opening_state': number[]; 'doors_locking_state': number}
*/
Have you an example of documentation? And where i set? Thank you
Co-authored-by: Florian BEZANNIER <[email protected]>
To solve this issue:
#962