gfx.nim: Drop duplicate libraries for linking #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, but shouldn't at least GL be linked? (for the theoretical case that sokol_gfx.h is used without sokol_app.h) PS: are you getting warnings about those duplicate libraries? I still need to thorougly test the Nim bindings on Linux (and Windows), maybe I missed that. |
|
You are absolutely correct, I have not gotten any warnings, but I was adding a switch for disabling X11 and it still linked all of the libraries and I was confused for a good 15 minutes. |
fleischie
force-pushed
the
chore/drop-duplicate-linker-flags
branch
from
8caaaf1 to
9960816
Compare
Firstly these are defined in src/sokol/app.nim and secondly these are not directly used in gfx.nim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am preparing the sokol nim-bindings for the wayland-feature, and stumbled about duplicate link-libraries when running the examples. These are due to
src/sokol/gfx.nimduplicating them.This PR removes them, and running them manually it seems to still compiles alright. (The libraries are still included via
src/sokol/app.nim) Additionally I am certain thatgfx.nimdoes not use these libraries directly.