Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plugins API #40

Merged
merged 40 commits into from
Feb 10, 2024
Merged

feat: plugins API #40

merged 40 commits into from
Feb 10, 2024

Conversation

florian-lefebvre
Copy link
Owner

@florian-lefebvre florian-lefebvre commented Feb 1, 2024 •
edited
Loading

TODO:

  • POC
  • Rework options definition (defineOptions)
  • Fix plugins types inference
  • Rework all hooks as core plugins
  • Allow passing nested arrays if plugins for presets
  • Test logic
  • Find a way to keep JSDoc in generics for plugins. should be possible by passing a manual generic somehow
  • Ensure imports use .js
  • Update docs
    • New functions JSDoc
    • Update existing docs
    • Add new docs
  • Update tests
  • Fix tabs/spaces
  • Open issues

@netlify Netlify
Copy link

netlify bot commented Feb 1, 2024 •
edited
Loading

✅ Deploy Preview for astro-integration-kit ready!

Name Link
🔨 Latest commit 7bc1d6b
🔍 Latest deploy log https://app.netlify.com/sites/astro-integration-kit/deploys/65c79415d985de00084b922f
😎 Deploy Preview https://deploy-preview-40--astro-integration-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review February 5, 2024 18:32
@florian-lefebvre florian-lefebvre changed the title [WIP] feat: plugins API feat: plugins API Feb 5, 2024
jdtjenkins
jdtjenkins previously requested changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@jdtjenkins jdtjenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @florian-lefebvre ! 👏

docs/src/content/docs/core/create-resolver.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/core/define-integration.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/core/define-options.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/core/define-options.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/core/define-plugin.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/getting-started/usage.mdx Show resolved Hide resolved
docs/src/content/docs/core/define-plugin.mdx Show resolved Hide resolved
docs/src/content/docs/core/define-options.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/core/define-options.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/core/define-integration.mdx Outdated Show resolved Hide resolved
Fryuni
Fryuni reviewed Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples in JSDocs are mixing tabs and spaces. The formatting gets all messed up depending on the editor intellisense rendering used while developing an integration

package/src/core/define-integration.ts Show resolved Hide resolved
package/src/core/define-integration.ts Show resolved Hide resolved
package/src/core/define-options.ts Outdated Show resolved Hide resolved
package/src/core/define-integration.ts Outdated Show resolved Hide resolved
Fryuni
Fryuni reviewed Feb 9, 2024
View reviewed changes
package/src/core/types.ts Outdated Show resolved Hide resolved
package/src/internal/types.ts Show resolved Hide resolved
package/src/internal/types.ts Outdated Show resolved Hide resolved
Fryuni
Fryuni approved these changes Feb 10, 2024
View reviewed changes
Copy link
Collaborator

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FANTASTIC!

package/src/utilities/add-vite-plugin.ts Show resolved Hide resolved
package/src/utilities/has-integration.ts Show resolved Hide resolved
@florian-lefebvre florian-lefebvre merged commit f05c7ab into main Feb 10, 2024
5 of 6 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/plugins-api branch February 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryuni Fryuni Fryuni approved these changes

@jdtjenkins jdtjenkins Awaiting requested review from jdtjenkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@florian-lefebvre @jdtjenkins @Fryuni