improving message for error in qgam + plot fixes #406

florianhartig · Oct 11, 2024 · d8e03c9 · d8e03c9
1 parent 38a313b
commit d8e03c9
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 12 deletions.
diff --git a/DHARMa/R/plots.R b/DHARMa/R/plots.R
@@ -181,7 +181,10 @@ plotQQunif <- function(simulationOutput, testUniformity = TRUE, testOutliers = T
 #' @seealso [plotQQunif], [testQuantiles], [testOutliers]
 #' @example inst/examples/plotsHelp.R
 #' @export
-plotResiduals <- function(simulationOutput, form = NULL, quantreg = NULL, rank = TRUE, asFactor = NULL, smoothScatter = NULL, quantiles = c(0.25, 0.5, 0.75), absoluteDeviation = FALSE, ...){
+plotResiduals <- function(simulationOutput, form = NULL, quantreg = NULL,
+                          rank = TRUE, asFactor = NULL, smoothScatter = NULL,
+                          quantiles = c(0.25, 0.5, 0.75),
+                          absoluteDeviation = FALSE, ...){
 
 
   ##### Checks #####
@@ -233,13 +236,17 @@ plotResiduals <- function(simulationOutput, form = NULL, quantreg = NULL, rank =
 
   # categorical plot
   if(is.factor(pred)){
-    testCategorical(simulationOutput = simulationOutput, catPred = pred, quantiles = quantiles)
+    testCategorical(simulationOutput = simulationOutput, catPred = pred,
+                    quantiles = quantiles)
   }
   # smooth scatter
   else if (smoothScatter == TRUE) {
     defaultCol = ifelse(res == 0 | res == 1, 2,blackcol)
-    do.call(graphics::smoothScatter, append(list(x = pred, y = res , ylim = c(0,1), axes = FALSE, colramp = colorRampPalette(c("white", "darkgrey"))),a))
-    points(pred[defaultCol == 2], res[defaultCol == 2], col = .Options$DHARMaSignalColor, cex = 0.5)
+    do.call(graphics::smoothScatter, append(list(x = pred, y = res ,
+                                                 ylim = c(0,1), axes = FALSE,
+                    colramp = colorRampPalette(c("white", "darkgrey"))),a))
+    points(pred[defaultCol == 2], res[defaultCol == 2],
+            col = .Options$DHARMaSignalColor, cex = 0.5)
 
     axis(1)
     axis(2, at=c(0, quantiles, 1))
@@ -266,14 +273,18 @@ plotResiduals <- function(simulationOutput, form = NULL, quantreg = NULL, rank =
       title(main = main, cex.main = 1)
       abline(h = quantiles, col = "black", lwd = 0.5, lty = 2)
       try({
-        lines(smooth.spline(pred, res, df = 10), lty = 2, lwd = 2, col = .Options$DHARMaSignalColor)
+        lines(smooth.spline(pred, res, df = 10), lty = 2, lwd = 2,
+              col = .Options$DHARMaSignalColor)
         abline(h = 0.5, col = .Options$DHARMaSignalColor, lwd = 2)
       }, silent = TRUE)
     }else{
 
       out = testQuantiles(res, pred, quantiles = quantiles, plot = FALSE)
 
-
+      if(is.na(out$p.value)){
+        main = paste(main, "Some quantile regressions failed", sep = "\n")
+        maincol = .Options$DHARMaSignalColor
+      } else{
       if(any(out$pvals < 0.05, na.rm = TRUE)){
         main = paste(main, "Quantile deviations detected (red curves)", sep ="\n")
         if(out$p.value <= 0.05){
@@ -286,7 +297,7 @@ plotResiduals <- function(simulationOutput, form = NULL, quantreg = NULL, rank =
         main = paste(main, "No significant problems detected", sep ="\n")
         maincol = "black"
       }
-
+    }
 
       title(main = main, cex.main = 0.8,
             col.main = maincol)
@@ -303,8 +314,6 @@ plotResiduals <- function(simulationOutput, form = NULL, quantreg = NULL, rank =
         lines(out$predictions$pred, out$predictions[,2*i], col = lineCol, lwd = 2)
       }
 
-      # legend("bottomright", c(paste("Quantile test: p=", round(out$p.value, digits = 5)), paste("Deviation ", ifelse(out$p.value < 0.05, "significant", "n.s."))), text.col = ifelse(out$p.value < 0.05, .Options$DHARMaSignalColor, "black" ), bty="n")
-
     }
   }
   invisible(out)

diff --git a/DHARMa/R/tests.R b/DHARMa/R/tests.R
@@ -119,7 +119,8 @@ testQuantiles <- function(simulationOutput, predictor = NULL, quantiles = c(0.25
                                                     data = datTemp,
                                                     qu = quantiles[i])), silent = T)
       if(inherits(quantResult, "try-error")){
-        message("Unable to calculate quantile regression for quantile ", quantiles[i], ". Possibly to few (unique) data points / predictions. Will be ommited in plots and significance calculations.")
+        message("\n DHARMa: qgam was unable to calculate quantile regression for quantile ",
+                quantiles[i], ". Possibly to few (unique) data points / predictions. The quantile will be ommited in plots and significance calculations. \n")
       } else {
         x = summary(quantileFits[[i]])
         pval[i] = min(p.adjust(c(x$p.table[1,4], x$s.table[1,4]), method = "BH")) # correction for test on slope and intercept
@@ -335,14 +336,17 @@ testOutliers <- function(simulationOutput, alternative = c("two.sided", "greater
 #' @seealso [testResiduals], [testUniformity], [testOutliers], [testDispersion], [testZeroInflation], [testGeneric], [testTemporalAutocorrelation], [testSpatialAutocorrelation], [testQuantiles], [testCategorical]
 #' @example inst/examples/testsHelp.R
 #' @export
-testCategorical <- function(simulationOutput, catPred, quantiles = c(0.25, 0.5, 0.75), plot = TRUE){
+testCategorical <- function(simulationOutput, catPred,
+                            quantiles = c(0.25, 0.5, 0.75), plot = TRUE){
 
   simulationOutput = ensureDHARMa(simulationOutput, convert = T)
 
   catPred = as.factor(catPred)
   out = list()
 
-  out$uniformity$details = suppressWarnings(by(simulationOutput$scaledResiduals, catPred, ks.test, 'punif', simplify = TRUE))
+  out$uniformity$details = suppressWarnings(by(simulationOutput$scaledResiduals,
+                                               catPred, ks.test, 'punif',
+                                               simplify = TRUE))
   out$uniformity$p.value = rep(NA, nlevels(catPred))
   for(i in 1:nlevels(catPred)) out$uniformity$p.value[i] = out$uniformity$details[[i]]$p.value
   out$uniformity$p.value.cor = p.adjust(out$uniformity$p.value)