-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FDN-3000: Upgrade libraries #589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gheine
commented
Nov 12, 2024
- com.datadoghq
- dd-java-agent (1.40.1 => 1.42.1)
- io.flow
- lib-log (0.2.27 => 0.2.28)
- lib-metrics-play28 (1.0.97 => 1.1.1)
- lib-postgresql-play-play28 (0.5.73 => 0.5.76)
- lib-test-utils-play28 (0.2.40 => 0.2.41)
- lib-usage-play28 (0.2.58 => 0.2.59)
- sbt-flow-linter (0.0.57 => 0.0.59)
- org.scoverage
- sbt-scoverage (2.2.1 => 2.2.2)
helm diff output for registry:production, registry, Service (v1) has changed:
# Source: flow-generic/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
name: registry
labels:
- helm.sh/chart: flow-generic-1.5.53
+ helm.sh/chart: flow-generic-1.5.58
app.kubernetes.io/instance: registry
app.kubernetes.io/managed-by: Tiller
app.kubernetes.io/name: registry
app: registry
spec:
ports:
- port: 80
targetPort: http
protocol: TCP
name: http
selector:
app.kubernetes.io/name: registry
app.kubernetes.io/instance: registry
production, registry-flow-io, Gateway (networking.istio.io) has changed:
# Source: flow-generic/templates/ingress-defaults.yaml
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
name: registry-flow-io
labels:
app.kubernetes.io/name: registry
- helm.sh/chart: flow-generic-1.5.53
+ helm.sh/chart: flow-generic-1.5.58
app.kubernetes.io/instance: registry
app.kubernetes.io/managed-by: Tiller
app: registry
annotations:
kubernetes.io/ingress.class: "ingressgateway"
kubernetes.io/ingress.tld: "api.flow.io"
external-dns.alpha.kubernetes.io/ttl: "120"
external-dns.alpha.kubernetes.io/target: "alb-prod.api.flow.io"
external-dns.alpha.kubernetes.io/alias: "true"
spec:
selector:
istio: ingressgateway
servers:
- port:
number: 80
name: http
protocol: HTTP2
hosts:
- registry.api.flow.io
tls:
httpsRedirect: true
- port:
number: 443
name: https
protocol: HTTP2
hosts:
- registry.api.flow.io
production, registry-live, Deployment (apps) has changed:
# Source: flow-generic/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
name: registry-live
labels:
- helm.sh/chart: flow-generic-1.5.53
+ helm.sh/chart: flow-generic-1.5.58
app.kubernetes.io/instance: registry
app.kubernetes.io/managed-by: Tiller
app.kubernetes.io/name: registry
app.kubernetes.io/stage: live
app: registry
tags.datadoghq.com/service: registry
tags.datadoghq.com/env: live
tags.datadoghq.com/version: 0.7.38
flow.io/version: 0.7.38
flow.io/team: foundation
spec:
replicas: 0
selector:
matchLabels:
app.kubernetes.io/name: registry
app.kubernetes.io/instance: registry
app.kubernetes.io/stage: live
template:
metadata:
labels:
app.kubernetes.io/name: registry
app.kubernetes.io/instance: registry
app.kubernetes.io/stage: live
app: registry
tags.datadoghq.com/service: registry
tags.datadoghq.com/env: live
tags.datadoghq.com/version: 0.7.38
flow.io/version: 0.7.38
flow.io/team: foundation
annotations:
iam.amazonaws.com/role: arn:aws:iam::479720515435:role/ecsInstanceRole
sumologic.com/sourceCategory: registry
sidecar.istio.io/logLevel: info
proxy.istio.io/config: '{"terminationDrainDuration": 60s}'
spec:
terminationGracePeriodSeconds: 60
containers:
- name: registry
image: "flowcommerce/registry:0.7.38"
imagePullPolicy: IfNotPresent
env:
- name: JAVA_OPTS
value: "-Xms500m -Xmx500m -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/dumps/oom.bin -XX:+UseG1GC -XX:+UseStringDeduplication -XX:FlightRecorderOptions=stackdepth=256"
- name: FLOW_KUBERNETES_NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: FLOW_KUBERNETES_NODE_IP
valueFrom:
fieldRef:
fieldPath: status.hostIP
- name: FLOW_KUBERNETES_POD_NAME
valueFrom:
fieldRef:
fieldPath: metadata.name
- name: FLOW_KUBERNETES_POD_NAMESPACE
valueFrom:
fieldRef:
fieldPath: metadata.namespace
- name: FLOW_KUBERNETES_POD_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
- name: FLOW_KUBERNETES_POD_UID
valueFrom:
fieldRef:
fieldPath: metadata.uid
- name: DD_SERVICE
value: registry
- name: DD_ENV
value: live
- name: DD_VERSION
value: 0.7.38
- name: DD_JMXFETCH_STATSD_HOST
value: 'unix:///var/run/datadog/dsd.socket'
- name: DD_DOGSTATSD_URL
value: 'unix:///var/run/datadog/dsd.socket'
- name: DD_TRACE_AGENT_URL
value: 'unix:///var/run/datadog/apm.socket'
- name: DD_SERVICE_MAPPING
value: "postgresql:registry-postgresql,java-aws-sdk:registry-aws-sdk"
- name: DD_TAGS
value: "team:foundation"
- name: DD_KUBERNETES_POD_LABELS_AS_TAGS
value: '{"*": "label_%%label%%"}'
- name: DD_CONTAINER_ENV_AS_TAGS
value: '{"FLOW_KUBERNETES_POD_NAME":"env_flow_kubernetes_pod_name","FLOW_KUBERNETES_POD_NAMESPACE":"env_flow_kubernetes_pod_namespace"}'
args: ["production"]
ports:
- name: http
containerPort: 9000
protocol: TCP
volumeMounts:
- name: dsdsocket
mountPath: /var/run/datadog
- name: heap-dumps
mountPath: /dumps
startupProbe:
httpGet:
path: /_internal_/startup
port: http
failureThreshold: 30
periodSeconds: 10
livenessProbe:
httpGet:
path: /_internal_/live
port: http
failureThreshold: 6
periodSeconds: 10
timeoutSeconds: 5
readinessProbe:
httpGet:
path: /_internal_/ready
port: http
failureThreshold: 1
periodSeconds: 10
timeoutSeconds: 1
resources:
limits:
memory: 1000Mi
requests:
cpu: 0.05
memory: 1000Mi
nodeSelector:
karpenter/role: workers
imagePullSecrets:
- name: flow-docker-hub
topologySpreadConstraints:
- maxSkew: 1
topologyKey: topology.kubernetes.io/zone
whenUnsatisfiable: DoNotSchedule
labelSelector:
matchLabels:
app: registry
tolerations:
- effect: NoSchedule
key: role
operator: Equal
value: workers
dnsConfig:
options:
- name: ndots
value: "1"
volumes:
- name: dsdsocket
hostPath:
path: /var/run/datadog/
type: DirectoryOrCreate
- name: heap-dumps
emptyDir: {}
strategy:
type: RollingUpdate
production, registry-rollout-live, VirtualService (networking.istio.io) has changed:
# Source: flow-generic/templates/istio-rollout.yaml
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
name: registry-rollout-live
labels:
app.kubernetes.io/name: registry
- helm.sh/chart: flow-generic-1.5.53
+ helm.sh/chart: flow-generic-1.5.58
app.kubernetes.io/instance: registry
app.kubernetes.io/managed-by: Tiller
app: registry
spec:
hosts:
- registry
- registry.api.flow.io
gateways:
- mesh
- registry-flow-io
http:
- name: primary
route:
- destination:
host: registry
port:
number: 80
subset: live
weight: 100
- destination:
host: registry
port:
number: 80
subset: canary
weight: 0 |
Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/registry/job/PR-589/1/scoverage-report/ |
nicolagi
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.