Merge pull request #15 from gromaco/master

BUGFIX: Filenames need to be rawurlencoded
flownative · Jan 10, 2018 · 62fd5a9 · 62fd5a9
2 parents 1a1f285 + b627a9b
commit 62fd5a9
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/Classes/S3Target.php b/Classes/S3Target.php
@@ -303,12 +303,23 @@ public function unpublishResource(PersistentResource $resource)
     public function getPublicPersistentResourceUri(PersistentResource $resource)
     {
         if ($this->baseUri != '') {
-            return $this->baseUri . $this->getRelativePublicationPathAndFilename($resource);
+            return $this->baseUri . $this->encodeRelativePathAndFilenameForUri($this->getRelativePublicationPathAndFilename($resource));
         } else {
             return $this->s3Client->getObjectUrl($this->bucketName, $this->keyPrefix . $this->getRelativePublicationPathAndFilename($resource));
         }
     }
 
+	/**
+	 * Applies rawurlencode() to all path segments of the given $relativePathAndFilename
+	 *
+	 * @param string $relativePathAndFilename
+	 * @return string
+	 */
+	protected function encodeRelativePathAndFilenameForUri($relativePathAndFilename)
+	{
+		return implode('/', array_map('rawurlencode', explode('/', $relativePathAndFilename)));
+	}
+
     /**
      * Publishes the specified source file to this target, with the given relative path.
      *