Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export the HttpHandlerOptions type #75

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

godu
Copy link
Contributor

@godu godu commented Nov 5, 2024

In my project (a monorepo), I have a package that wraps @effect-aws/* packages with a schema validation.

const opensearch = Effect.serviceFunctions(OpenSearchService);

export const listDomainNames = flow(
  opensearch.listDomainNames,
  Effect.flatMap(S.validate(ListDomainNamesCommandOutputSchema)),
);

Typescript isn't able to re-export the HttpHandlerOptions type.

Exported variable 'listDomainNames' has or is using name 'HttpHandlerOptions' from external module "./node_modules/@effect-aws/client-opensearch/lib/OpenSearchService" but cannot be named.

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: af85f91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@effect-aws/client-api-gateway-management-api Patch
@effect-aws/client-cognito-identity-provider Patch
@effect-aws/client-opensearch-serverless Patch
@effect-aws/client-cloudwatch-events Patch
@effect-aws/client-cloudwatch-logs Patch
@effect-aws/client-secrets-manager Patch
@effect-aws/client-cloudsearch Patch
@effect-aws/client-elasticache Patch
@effect-aws/client-eventbridge Patch
@effect-aws/client-cloudtrail Patch
@effect-aws/client-cloudwatch Patch
@effect-aws/client-codedeploy Patch
@effect-aws/client-opensearch Patch
@effect-aws/client-scheduler Patch
@effect-aws/client-dynamodb Patch
@effect-aws/client-account Patch
@effect-aws/client-kinesis Patch
@effect-aws/client-lambda Patch
@effect-aws/lib-dynamodb Patch
@effect-aws/client-ec2 Patch
@effect-aws/client-iam Patch
@effect-aws/client-kms Patch
@effect-aws/client-rds Patch
@effect-aws/client-sfn Patch
@effect-aws/client-sns Patch
@effect-aws/client-sqs Patch
@effect-aws/client-ssm Patch
@effect-aws/client-sts Patch
@effect-aws/client-mq Patch
@effect-aws/client-s3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@godu godu force-pushed the feat/export-httphandleroptions branch from df69511 to 876fd65 Compare November 5, 2024 10:09
@godu godu force-pushed the feat/export-httphandleroptions branch from 876fd65 to af85f91 Compare November 5, 2024 10:21
Copy link
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@floydspace floydspace merged commit 9dc170d into floydspace:main Nov 5, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
@godu godu deleted the feat/export-httphandleroptions branch November 5, 2024 21:53
This was referenced Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants