Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public docs for oci logging analytics #1186

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

adiforluls
Copy link
Member

@adiforluls adiforluls commented Aug 30, 2023

This PR is for documentation of Oracle Cloud Infrastructure Logging Analytics output plugin.
Corresponds to fluent/fluent-bit#7830

@adiforluls
Copy link
Member Author

cc: @edsiper @patrick-stephens

Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few niggles.

How would you suspect people would use this? Wondering if we should expand the examples away from just dummy input to real scenarios?

pipeline/outputs/oci-logging-analytics.md Outdated Show resolved Hide resolved
pipeline/outputs/oci-logging-analytics.md Show resolved Hide resolved
pipeline/outputs/oci-logging-analytics.md Show resolved Hide resolved
@patrick-stephens
Copy link
Contributor

Please also update the description and link back to the original PR in the code.

Signed-off-by: adiforluls <[email protected]>
Signed-off-by: adiforluls <[email protected]>
Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description and link back to the original code change PR too.

@adiforluls
Copy link
Member Author

Done @patrick-stephens

@adiforluls
Copy link
Member Author

Hi @patrick-stephens , the main code is merged. This PR can be merged now

@patrick-stephens
Copy link
Contributor

Hi @patrick-stephens , the main code is merged. This PR can be merged now

Not until it's in a release usually, otherwise it'll confuse people expecting to use it with the official binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants