processor_labels: Remove a needless existence check for insert operation

Insert implies that adding new key-value pairs of labels. However, we did put the existence check for the keys of labels. This shouldn't be effective for such operation Signed-off-by: Hiroshi Hatake <[email protected]>
fluent · May 14, 2024 · 2f9053b · 2f9053b
1 parent ce7aafa
commit 2f9053b
Showing 1 changed file with 13 additions and 19 deletions.
diff --git a/plugins/processor_labels/labels.c b/plugins/processor_labels/labels.c
@@ -1520,32 +1520,26 @@ static int insert_labels(struct cmt *metrics_context,
     cfl_list_foreach(iterator, labels) {
         pair = cfl_list_entry(iterator, struct cfl_kv, _head);
 
-        result = metrics_context_contains_dynamic_label(metrics_context,
-                                                        pair->key);
+        result = metrics_context_insert_dynamic_label(metrics_context,
+                                                      pair->key,
+                                                      pair->val);
+
+        if (result == FLB_FALSE) {
+            return FLB_FALSE;
+        }
+
+        result = metrics_context_contains_static_label(metrics_context,
+                                                       pair->key);
 
         if (result == FLB_TRUE) {
-            result = metrics_context_insert_dynamic_label(metrics_context,
-                                                          pair->key,
-                                                          pair->val);
+            result = metrics_context_insert_static_label(metrics_context,
+                                                         pair->key,
+                                                         pair->val);
 
             if (result == FLB_FALSE) {
                 return FLB_FALSE;
             }
         }
-        else {
-            result = metrics_context_contains_static_label(metrics_context,
-                                                           pair->key);
-
-            if (result == FLB_FALSE) {
-                result = metrics_context_insert_static_label(metrics_context,
-                                                             pair->key,
-                                                             pair->val);
-
-                if (result == FLB_FALSE) {
-                    return FLB_FALSE;
-                }
-            }
-        }
     }
 
     return FLB_PROCESSOR_SUCCESS;