fix: remove retries

following comments in the PR, the preferred option is to remove the ineffective retries option and the mask that would have caused it to have any effect. The resulting code should behave exactly as before, since the mask was required for the original retries option to work, and it has never been set; so no additonal tests are supplied. Signed-off-by: bazzargh <[email protected]>
fluent · Apr 12, 2024 · a2fc10e · a2fc10e
1 parent 8d22ee4
commit a2fc10e
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/flb_network.c b/src/flb_network.c
@@ -996,12 +996,9 @@ static struct flb_dns_lookup_context *flb_net_dns_lookup_context_create(
         return NULL;
     }
 
-    /* c-ares options: Set the transport layer to the desired protocol and
-     *                 the number of retries to 2
-     */
+    /* c-ares options: Set the transport layer to the desired protocol */
 
-    optmask = ARES_OPT_FLAGS | ARES_OPT_TRIES;
-    opts.tries = 2;
+    optmask = ARES_OPT_FLAGS;
 
     if (dns_mode == FLB_DNS_USE_TCP) {
         opts.flags = ARES_FLAG_USEVC;