Skip to content

Commit

Permalink
docs: Comments on windows workflows
Browse files Browse the repository at this point in the history
Add comments on the Windows workflows to cross-reference them
with each other and the new DEVELOPER_GUIDE.md docs section for Windows
builds.

Add a short note to the windows PR workflow on how to run it manually
on a forked repo when submitting patches.

Signed-off-by: Craig Ringer <[email protected]>
  • Loading branch information
ringerc authored and edsiper committed Dec 19, 2023
1 parent 7cbee16 commit ff2962f
Show file tree
Hide file tree
Showing 4 changed files with 44 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/call-build-windows.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
---
name: Reusable workflow to build Windows packages optionally into S3 bucket

#
# If you change dependencies etc here, please also check and update
# the other Windows build resources:
#
# - DEVELOPER_GUIDE.md "Windows" section
# - appveyor.yml
# - .github/workflows/call-build-windows.yaml
# - dockerfiles/Dockerfile.windows
#

on:
workflow_call:
inputs:
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/pr-windows-build.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
name: PR - Windows checks

#
# Test PRs on Windows
#
# This won't run automatically on PRs from untrusted repos, it must be approved
# manually. If PR authors want to run it themselves, they should enable running
# actions on their fork, then invoke it on their branch via their forked repo's
# Actions tab.
#

on:
# Enable invocation via Github repo Actions tab. Having this in the repo
# allows people with github forks to run this job on their own branches to
# build Windows branches conveniently. See DEVELOPER_GUIDE.md.
workflow_dispatch:

pull_request:
Expand Down
10 changes: 10 additions & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
version: v1-winbuild-{build}

#
# If you change dependencies etc here, please also check and update
# the other Windows build resources:
#
# - DEVELOPER_GUIDE.md "Windows" section
# - appveyor.yml
# - .github/workflows/call-build-windows.yaml
# - dockerfiles/Dockerfile.windows
#

image: Visual Studio 2019

platform:
Expand Down
11 changes: 11 additions & 0 deletions dockerfiles/Dockerfile.windows
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# escape=`

# This Dockerfile will only build on Docker for Windows.
#
# If you change dependencies etc here, please also check and update
# the other Windows build resources:
#
# - DEVELOPER_GUIDE.md "Windows" section
# - appveyor.yml
# - .github/workflows/call-build-windows.yaml
# - dockerfiles/Dockerfile.windows
#

ARG WINDOWS_VERSION=ltsc2019

# Builder Image - Windows Server Core
Expand Down

0 comments on commit ff2962f

Please sign in to comment.