Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check last error after flb_log_event_decoder_next #7636

Closed
5 of 24 tasks
nokute78 opened this issue Jul 1, 2023 · 3 comments
Closed
5 of 24 tasks

Check last error after flb_log_event_decoder_next #7636

nokute78 opened this issue Jul 1, 2023 · 3 comments

Comments

@nokute78
Copy link
Collaborator

nokute78 commented Jul 1, 2023

Bug Report

Original issue is #7362
We need to check if last decoder error is a real error or end of buffer using flb_log_event_decoder_get_last_result
#7362 (comment)

 there's a patch for that we've been applying in other plugins which conditionally switches the result code when it's FLB_EVENT_DECODER_ERROR_INSUFFICIENT_DATA and the input buffer offset matches the input buffer size (in the decoder state).

See also #7540

Following plugins are using flb_log_event_decoder_next.

  • in_lib in_lib: fix error handling after flb_log_event_decoder_next #7669
  • [N/A] in_tail
    • It doesn't check error.
  • [N/A] filter_alter_size
    • It doesn't check error.
  • filter_aws
  • filter_checklist
  • filter_ecs
  • filter_expect
  • filter_geoip2
  • filter_grep
  • filter_k8s
  • filter_lua
  • filter_modify filter_modify: fix error handling after flb_log_event_decoder_next #7641
  • filter_multiline
  • filter_nest
  • filter_nightfall
  • filter_parser
  • filter_record_modifier
  • filter_rewrite_tag
  • [N/A] filter_stdout
    • It doesn't check error.
  • filter_tensorflow
  • [N/A] filter_throttle
    • It doesn't check error.
  • filter_throttle_size
  • filter_type_converter filter_type_converter: fix error handling after flb_log_event_decoder_next #7666
  • filter_wasm
  • [N/A] out_azure
    • It doesn't check error.
  • [N/A] out_azure_kusto
    • It doesn't check error.
  • [N/A] out_bigquery
    • It doesn't check error.
  • [N/A] out_cloudwatch_logs
    • It doesn't check error.
  • [N/A] out_datadog
    • It doesn't check error.
  • [N/A] out_es
    • It doesn't check error.
  • [N/A] out_flowcounter
    • It doesn't check error.
  • [N/A] out_file
    • It doesn't check error.
  • out_forward
  • [N/A] out_gelf
    • It doesn't check error.
  • [N/A] out_http
    • It doesn't check error.
  • [N/A] out_influxdb
    • It doesn't check error.
  • [N/A] out_kafka
    • It doesn't check error.
  • [N/A] out_kafka_rest
    • It doesn't check error.
  • [N/A] out_kinesis_firehose
    • It doesn't check error.
  • [N/A] out_kinesis_streams
    • It doesn't check error.
  • [N/A] out_logdna
    • It doesn't check error.
  • [N/A] out_loki
    • It doesn't check error.
  • [N/A] out_nats
    • It doesn't check error.
  • [N/A] out_nrlogs
    • It doesn't check error.
  • [N/A] out_opensearch
    • It doesn't check error.
  • [N/A] out_opentelemetry
    • It doesn't check error.
  • [N/A] out_plot
    • It doesn't check error.
  • [N/A] out_s3
    • It doesn't check error.
  • [N/A] out_skywalking
    • It doesn't check error.
  • [N/A] out_slack
    • It doesn't check error.
  • [N/A] out_splunk
    • It doesn't check error.
  • out_stackdriver
  • out_stdout
  • out_syslog out_syslog: check error after flb_log_event_decoder_next #7639
    • No error verification except for test code.
  • [N/A] out_tcp
    • It doesn't check error.
  • [N/A] out_td
    • It doesn't check error.
  • [N/A] out_udp
    • It doesn't check error.
  • [N/A] out_vivo_exporter
    • It doesn't check error.

Describe the bug

To Reproduce

  • Rubular link if applicable:

  • Example log message if applicable:

  • Steps to reproduce the problem:

Expected behavior

Screenshots

Your Environment

  • Version used:
  • Configuration:
  • Environment name and version (e.g. Kubernetes? What version?):
  • Server type and version:
  • Operating System and version:
  • Filters and plugins:

Additional context

Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

@github-actions github-actions bot added the Stale label Dec 11, 2023
@nokute78 nokute78 removed the Stale label Dec 15, 2023
Copy link
Contributor

github-actions bot commented Apr 7, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days. Maintainers can add the exempt-stale label.

@github-actions github-actions bot added the Stale label Apr 7, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant