filter_modify: fix error handling after flb_log_event_decoder_next #7641

nokute78 · 2023-07-02T01:27:48Z

This patch is to fix error verification after flb_log_event_decoder_next.
See also #7636

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

[N/A] Example configuration file for the change
Debug log output from testing the change

Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

[N/A] Run local packaging test showing all targets (including any new ones) build.
[N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

[N/A] Documentation required for this feature

Backporting

[N/A] Backport to latest stable release.

Debug/Valgrind output

$ valgrind --leak-check=full bin/flb-rt-filter_modify 
==27271== Memcheck, a memory error detector
==27271== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==27271== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==27271== Command: bin/flb-rt-filter_modify
==27271== 
Test op_set_append...                           [2023/07/02 10:21:48] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:21:48] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:21:48] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:21:48] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:21:48] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:21:48] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:21:48] [ info] [sp] stream processor started
[2023/07/02 10:21:49] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:21:50] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_set_replace...                          [2023/07/02 10:21:50] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:21:50] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:21:50] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:21:50] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:21:50] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:21:50] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:21:50] [ info] [sp] stream processor started
[2023/07/02 10:21:51] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:21:52] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_remove...                               [2023/07/02 10:21:52] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:21:52] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:21:52] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:21:52] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:21:52] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:21:52] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:21:52] [ info] [sp] stream processor started
[2023/07/02 10:21:53] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:21:54] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_remove_wildcard...                      [2023/07/02 10:21:54] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:21:54] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:21:54] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:21:54] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:21:54] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:21:54] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:21:54] [ info] [sp] stream processor started
[2023/07/02 10:21:55] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:21:56] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_remove_regex...                         [2023/07/02 10:21:56] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:21:56] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:21:56] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:21:56] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:21:56] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:21:56] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:21:56] [ info] [sp] stream processor started
[2023/07/02 10:21:57] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:21:58] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_rename_exists...                        [2023/07/02 10:21:58] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:21:58] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:21:58] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:21:58] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:21:58] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:21:58] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:21:58] [ info] [sp] stream processor started
[2023/07/02 10:21:59] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:00] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_rename_no_exists...                     [2023/07/02 10:22:00] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:00] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:00] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:00] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:00] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:00] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:00] [ info] [sp] stream processor started
[2023/07/02 10:22:01] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:02] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_hard_rename_exists...                   [2023/07/02 10:22:02] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:02] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:02] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:02] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:02] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:02] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:02] [ info] [sp] stream processor started
[2023/07/02 10:22:03] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:04] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_hard_rename_no_exists...                [2023/07/02 10:22:04] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:04] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:04] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:04] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:04] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:04] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:04] [ info] [sp] stream processor started
[2023/07/02 10:22:05] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:06] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_copy_exists...                          [2023/07/02 10:22:06] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:06] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:06] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:06] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:06] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:06] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:06] [ info] [sp] stream processor started
[2023/07/02 10:22:07] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:08] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_copy_no_exists...                       [2023/07/02 10:22:08] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:08] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:08] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:08] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:08] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:08] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:08] [ info] [sp] stream processor started
[2023/07/02 10:22:09] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:10] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_hard_copy_exists...                     [2023/07/02 10:22:10] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:10] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:10] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:10] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:10] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:10] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:10] [ info] [sp] stream processor started
[2023/07/02 10:22:11] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:12] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test op_hard_copy_no_exists...                  [2023/07/02 10:22:12] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:12] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:12] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:12] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:12] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:12] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:12] [ info] [sp] stream processor started
[2023/07/02 10:22:13] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:14] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_matches_nest...             [2023/07/02 10:22:14] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:14] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:14] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:14] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:14] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:14] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:14] [ info] [sp] stream processor started
[2023/07/02 10:22:15] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:16] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_does_not_match_nest...      [2023/07/02 10:22:16] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:16] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:16] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:16] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:16] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:16] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:16] [ info] [sp] stream processor started
[2023/07/02 10:22:17] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:18] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_exists_nest...                    [2023/07/02 10:22:18] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:18] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:18] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:18] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:18] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:18] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:18] [ info] [sp] stream processor started
[2023/07/02 10:22:19] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:20] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_does_not_exist_nest...            [2023/07/02 10:22:20] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:20] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:20] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:20] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:20] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:20] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:20] [ info] [sp] stream processor started
[2023/07/02 10:22:21] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:22] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_equals_nest...              [2023/07/02 10:22:22] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:22] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:22] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:22] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:22] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:22] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:22] [ info] [sp] stream processor started
[2023/07/02 10:22:23] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:24] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_does_not_equal_nest...      [2023/07/02 10:22:24] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:24] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:24] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:24] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:24] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:24] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:24] [ info] [sp] stream processor started
[2023/07/02 10:22:25] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:26] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_exists...                         [2023/07/02 10:22:26] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:26] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:26] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:26] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:26] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:26] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:26] [ info] [sp] stream processor started
[2023/07/02 10:22:27] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:28] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_does_not_exist...                 [2023/07/02 10:22:28] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:28] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:28] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:28] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:28] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:28] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:28] [ info] [sp] stream processor started
[2023/07/02 10:22:29] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:30] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_a_key_matches...                      [2023/07/02 10:22:30] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:30] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:30] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:30] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:30] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:30] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:30] [ info] [sp] stream processor started
[2023/07/02 10:22:31] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:32] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_no_key_matches...                     [2023/07/02 10:22:32] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:32] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:32] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:32] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:32] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:32] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:32] [ info] [sp] stream processor started
[2023/07/02 10:22:33] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:34] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_equals...                   [2023/07/02 10:22:34] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:34] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:34] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:34] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:34] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:34] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:34] [ info] [sp] stream processor started
[2023/07/02 10:22:35] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:36] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_does_not_equal...           [2023/07/02 10:22:36] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:36] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:36] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:36] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:36] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:36] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:36] [ info] [sp] stream processor started
[2023/07/02 10:22:37] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:38] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_matches...                  [2023/07/02 10:22:38] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:38] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:38] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:38] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:38] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:38] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:38] [ info] [sp] stream processor started
[2023/07/02 10:22:39] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:40] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_does_not_match...           [2023/07/02 10:22:40] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:40] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:40] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:40] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:40] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:40] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:40] [ info] [sp] stream processor started
[2023/07/02 10:22:41] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:42] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_matching_keys_have_matching_values... [2023/07/02 10:22:42] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:42] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:42] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:42] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:42] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:42] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:42] [ info] [sp] stream processor started
[2023/07/02 10:22:43] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:44] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_matching_keys_do_not_have_matching_values... [2023/07/02 10:22:44] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:44] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:44] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:44] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:44] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:44] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:44] [ info] [sp] stream processor started
[2023/07/02 10:22:45] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:46] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_chain...                              [2023/07/02 10:22:46] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:46] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:46] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:46] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:46] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:46] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:46] [ info] [sp] stream processor started
[2023/07/02 10:22:47] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:48] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test multiple events are not dropped...         [2023/07/02 10:22:48] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:48] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:48] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:48] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:48] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:48] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:48] [ info] [sp] stream processor started
[2023/07/02 10:22:50] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:51] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_does_not_equal and key does not exist... [2023/07/02 10:22:51] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:51] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:51] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:51] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:51] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:51] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:51] [ info] [sp] stream processor started
[2023/07/02 10:22:53] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:54] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test cond_key_value_does_not_matches and key does not exist... [2023/07/02 10:22:54] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:54] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:54] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:54] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:54] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:54] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:54] [ info] [sp] stream processor started
[2023/07/02 10:22:56] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:22:57] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test Key_value_matches and value is bool type... [2023/07/02 10:22:57] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:22:57] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:22:57] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:22:57] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:22:57] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:22:57] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:22:57] [ info] [sp] stream processor started
[2023/07/02 10:22:59] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:23:00] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test operation_with_whitespace...               [2023/07/02 10:23:00] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:23:00] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:23:00] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:23:00] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:23:00] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:23:00] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:23:00] [ info] [sp] stream processor started
[2023/07/02 10:23:01] [ warn] [engine] service will shutdown in max 1 seconds
[2023/07/02 10:23:02] [ info] [engine] service has stopped (0 pending tasks)
[ OK ]
Test invalid_wildcard...                        [2023/07/02 10:23:02] [ info] [fluent bit] version=2.1.7, commit=f70462c100, pid=27271
[2023/07/02 10:23:02] [ info] [storage] ver=1.2.0, type=memory, sync=normal, checksum=off, max_chunks_up=128
[2023/07/02 10:23:02] [ info] [cmetrics] version=0.6.2
[2023/07/02 10:23:02] [ info] [ctraces ] version=0.3.1
[2023/07/02 10:23:02] [ info] [input:lib:lib.0] initializing
[2023/07/02 10:23:02] [ info] [input:lib:lib.0] storage_strategy='memory' (memory only)
[2023/07/02 10:23:02] [error] [filter:modify:modify.0] Unable to create regex(key) from *s3
[2023/07/02 10:23:02] [error] Failed initialize filter modify.0
[2023/07/02 10:23:02] [error] [engine] filter initialization failed
[2023/07/02 10:23:02] [error] [lib] backend failed
[ OK ]
SUCCESS: All unit tests have passed.
==27271== 
==27271== HEAP SUMMARY:
==27271==     in use at exit: 0 bytes in 0 blocks
==27271==   total heap usage: 56,316 allocs, 56,316 frees, 28,241,076 bytes allocated
==27271== 
==27271== All heap blocks were freed -- no leaks are possible
==27271== 
==27271== For lists of detected and suppressed errors, rerun with: -s
==27271== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

nokute78 · 2023-07-02T01:30:52Z

plugins/filter_modify/modify.c

-        if (ret == FLB_EVENT_ENCODER_SUCCESS) {
-            *out_buf  = log_encoder.output_buffer;
-            *out_size = log_encoder.output_length;
+    if (total_modifications <= 0) {


This is a early return to simplify.
https://github.com/fluent/fluent-bit/blob/v2.1.6/plugins/filter_modify/modify.c#L1545
https://github.com/fluent/fluent-bit/blob/v2.1.6/plugins/filter_modify/modify.c#L1566

github-actions · 2023-12-11T01:50:57Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Signed-off-by: Takahiro Yamashita <[email protected]>

nokute78 · 2023-12-15T23:58:01Z

Updated using current master

github-actions · 2024-04-07T01:50:16Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions · 2024-07-14T01:59:00Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions · 2024-11-27T02:09:51Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

nokute78 requested review from edsiper, leonardo-albertovich, fujimotos and koleini as code owners July 2, 2023 01:27

github-actions bot added the docs-required label Jul 2, 2023

nokute78 temporarily deployed to pr July 2, 2023 01:28 — with GitHub Actions Inactive

nokute78 mentioned this pull request Jul 2, 2023

Check last error after flb_log_event_decoder_next #7636

Closed

24 tasks

nokute78 commented Jul 2, 2023

View reviewed changes

nokute78 temporarily deployed to pr July 2, 2023 01:51 — with GitHub Actions Inactive

github-actions bot added the Stale label Dec 11, 2023

filter_modify: fix error handling after flb_log_event_decoder_next

f781a20

Signed-off-by: Takahiro Yamashita <[email protected]>

nokute78 force-pushed the filter_modify_check_last_error branch from 3eb0b9a to f781a20 Compare December 15, 2023 23:57

nokute78 had a problem deploying to pr December 15, 2023 23:58 — with GitHub Actions Failure

nokute78 temporarily deployed to pr December 15, 2023 23:58 — with GitHub Actions Inactive

github-actions bot removed the Stale label Dec 18, 2023

github-actions bot added the Stale label Apr 7, 2024

nokute78 removed the Stale label Apr 12, 2024

github-actions bot added the Stale label Jul 14, 2024

github-actions bot removed the Stale label Aug 16, 2024

github-actions bot added the Stale label Nov 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

filter_modify: fix error handling after flb_log_event_decoder_next #7641

filter_modify: fix error handling after flb_log_event_decoder_next #7641

nokute78 commented Jul 2, 2023

nokute78 Jul 2, 2023

github-actions bot commented Dec 11, 2023

nokute78 commented Dec 15, 2023

github-actions bot commented Apr 7, 2024

github-actions bot commented Jul 14, 2024

github-actions bot commented Nov 27, 2024

filter_modify: fix error handling after flb_log_event_decoder_next #7641

Are you sure you want to change the base?

filter_modify: fix error handling after flb_log_event_decoder_next #7641

Conversation

nokute78 commented Jul 2, 2023

Debug/Valgrind output

nokute78 Jul 2, 2023

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2023

nokute78 commented Dec 15, 2023

github-actions bot commented Apr 7, 2024

github-actions bot commented Jul 14, 2024

github-actions bot commented Nov 27, 2024