Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve Kubernetes pod IP address if it is set in status.podIP #2783

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

kgtw
Copy link
Contributor

@kgtw kgtw commented Nov 18, 2020

This PR exposes the Kubernetes pod IP address if it has been set.

Fixes: #2301


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [ N/A ] Example configuration file for the change
  • [ N/A ] Debug log output from testing the change
  • [ N/A ] Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [ N/A ] Documentation required for this feature

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@kgtw kgtw force-pushed the k8s-pod-ip branch 2 times, most recently from 93fcf8b to 573c19b Compare November 18, 2020 09:31
Signed-off-by: Kris Gambirazzi <[email protected]>
@kgtw
Copy link
Contributor Author

kgtw commented Feb 4, 2021

@edsiper @fujimotos @koleini any chance of getting a review on this?

@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Mar 23, 2021
@kgtw
Copy link
Contributor Author

kgtw commented Mar 23, 2021

@edsiper @fujimotos @koleini ?

@github-actions github-actions bot removed the Stale label Mar 24, 2021
@github-actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Apr 27, 2021
@kgtw
Copy link
Contributor Author

kgtw commented Jul 29, 2021

@edsiper @fujimotos @koleini any chance of getting a review on this?

@github-actions github-actions bot removed the Stale label Jul 30, 2021
@artemlive
Copy link

@kgtw thanks for such useful improvement, I hope it will be reviewed and merged.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Oct 6, 2021
@syndbg
Copy link

syndbg commented Nov 1, 2021

Can we get some response about this PR? It's something really needed for fluent-bit users.

Promtrail already supports it and it's a shame if we're forced to migrate "just cause" we can't have a pod IP.

@github-actions github-actions bot removed the Stale label Jan 4, 2022
@askuy
Copy link

askuy commented Mar 21, 2022

@kgtw thanks for such useful improvement, I hope it will be reviewed and merged.

@sevennt
Copy link

sevennt commented Mar 21, 2022

@edsiper how about this PR?

@raxidex
Copy link

raxidex commented May 26, 2022

Hello. Any news on this PR?

@dan-leanix
Copy link

dan-leanix commented Jun 13, 2022

@edsiper @fujimotos @koleini Any chance that this PR gets merged? It is funny that in the documentation it is stated

Our Kubernetes Filter plugin is fully inspired by the Fluentd Kubernetes Metadata Filter written by Jimmi Dyson.

but the pod IP is missing in the Kubernetes filter for Fluent Bit. Depending on the use case the pod IP is an important piece of metadata.

Thanks.

@patrick-stephens
Copy link
Contributor

Can you rebase to force the various checks to run? I'm guessing it was Github issues at the time.

@dan-leanix
Copy link

Can you rebase to force the various checks to run? I'm guessing it was Github issues at the time.

@kgtw FYI.

@dan-leanix
Copy link

@patrick-stephens I guess someone from the reviewers' list needs to approve the PR first before the various checks can run. At least that is what I read from the Action itself.

-> https://github.com/fluent/fluent-bit/actions/runs/2568072268

image

@patrick-stephens
Copy link
Contributor

@dan-leanix yeah it's to help with security and prevent spurious PRs causing issues as they will run on the Fluent resources. Plus quite often an initial review will highlight some issues that need resolving immediately anyway so not worth running until those are done.

@dan-leanix
Copy link

Thanks, @patrick-stephens for the explanation. It makes total sense.

@kgtw Seems to be that the issue with the tests is that the expected record does not match the actual record. Hence, the expected record is missing the pod_ip.

 filter_kubernetes.c:156: Check comparing expected record with actual record... failed

@raxidex
Copy link

raxidex commented Oct 7, 2022

Hi @kgtw, would it be possible to finish this PR? Thanks for the effort

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 6, 2023
@mrueg
Copy link
Contributor

mrueg commented Jun 25, 2024

@edsiper I know this PR is quite old, but would this be something you'd be up to adding to fluent-bit? It would help a lot with migrating from fluentd.

@github-actions github-actions bot removed the Stale label Jun 26, 2024
@ivanvc
Copy link

ivanvc commented Jun 28, 2024

Is there any path forward with this pull request? We're also migrating from fluentd, and this field is missing in fluent bit.
It would be great to get some feedback so that someone else can take over the PR if the original contributor is unavailable.

@ziyuen
Copy link

ziyuen commented Jul 12, 2024

Waiting for this PR. We are migrating to fluent-bit

@kgtw
Copy link
Contributor Author

kgtw commented Jul 27, 2024

Hi to all who've commented 👋

If there is anybody who would like to take over, feel free to. I've since moved on to other engineering domains so am no longer active in this space.

After this PR had no interest from the maintainers within the first two years of it being opened I gave up any hope of it ever being merged.

I still believe the intent behind this PR holds merit that many would benefit from and hope that the maintainers see from the continued activity within this PR that people are still looking for a solution.

@edsiper
Copy link
Member

edsiper commented Nov 13, 2024

The code looks ok to me, however the unit test seems not to consider a proper input file and just validate the output, I have my doubts. Unit test is pending.

@edsiper edsiper merged commit a15cc20 into fluent:master Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kube_filter : Extracting ip address of the pod as one of the metadata