-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_es: add missing condition to create static bulk header #7513
base: master
Are you sure you want to change the base?
out_es: add missing condition to create static bulk header #7513
Conversation
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Signed-off-by: Takahiro Yamashita <[email protected]>
c39c13a
to
4f1b95c
Compare
Rebased using current master |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
In some cases out_es creates a bulk header
j_index
dynamically.One of the cases is
ctx->ra_id_key
is not NULL.https://github.com/fluent/fluent-bit/blob/v2.1.4/plugins/out_es/es.c#L537
Otherwise, it is created statically.
https://github.com/fluent/fluent-bit/blob/v2.1.4/plugins/out_es/es.c#L359
This patch is to add missing condition for static header.
Note: out_opensearch is already support similar condition.
https://github.com/fluent/fluent-bit/blob/v2.1.4/plugins/out_opensearch/opensearch.c#L346
https://github.com/fluent/fluent-bit/blob/v2.1.4/plugins/out_opensearch/opensearch.c#L483
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Debug/Valgrind output
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.