-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: fix compilation with FLB_HAVE_STATIC_CONF. #7536
Conversation
5808378
to
cfa359f
Compare
We noticed this when trying to move to 2.1.x; but I'm not sure which branch to target for "Backport to latest stable release," ( |
e6bc4f6
to
85697d5
Compare
|
Thanks @patrick-stephens :-) To confirm, the bug is not present in the 2.0 branch as the sighup config reloading feature hasn't been backported to 2.0, so have just left the backport for now - hopefully that's alright :-) |
Hello, we were just wondering if this is waiting for anything additional on our side? :-) Not a stress if no one's had a chance to have look and it's just waiting for that, but wanted to check as it's a fairly simple compile error that it would be great to fix, so just wanted to check :-) Thanks, and sorry for the noise :-) |
85697d5
to
ea04b9b
Compare
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
ea04b9b
to
a96667b
Compare
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Fixes the following compilation error: ``` /tmp/fluent-bit/src/fluent-bit.c:607:10: error: label at end of compound statement case SIGHUP: ^~~~~~ ``` Signed-off-by: Bryce Gibson <[email protected]>
a96667b
to
87e484e
Compare
@patrick-stephens sorry to pester; but is there anything we could do to help get this merged? It's still broken in master :-s It would appear to be a relatively unused feature (I guess?), but we do find it useful, so it would be nice to fix up |
I'm not a codeowner so cannot review this section but I'll ping @edsiper and @leonardo-albertovich to see if they can look. It would help to have some way to test it - this will also prevent it in the future. Any CI we can add to help? |
Ah, thanks for the note @patrick-stephens :-) And for the extra pings :-) I can have a look into getting a test for this; although it hadn't been immediately obvious when I'd looked previously - but I'll see if I can take another look soon ish All it needs is a build with the |
This is a small change to fix a compilation error when using
FLB_HAVE_STATIC_CONF
.Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.