-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: in_exec: enable on win32 #7664
Conversation
I don't have any idea how to add test cover for this and I've torn down my Windows dev-env after completion of work on #7207. Feel free to merge this change if you wish to do so based on the github test runs etc. |
Work done as part of fluent#7207 made the in_exec plugin build-able on Windows, but did not enable it as part of the build. Enable its compliation on Windows. Signed-off-by: Craig Ringer <[email protected]>
761676e
to
2ecab36
Compare
@patrick-stephens probably needs |
Please also merge #7463 |
I've kicked off a local Windows build via github actions as https://github.com/ringerc/fluent-bit/actions/runs/5481401003 Presumably this won't run any relevant tests for the functionality, since otherwise it'd have failed on The build succeeded anyway. |
I've triggered the build, otherwise looks good to me. |
@patrick-stephens Failed tests look like the usual ones I've seen failing on prior PRs. Got a Windows machine you can do a quick sanity check on? I tried it with Wine, but it didn't want to behave with Wayland and I gave up. Don't really want to spin up another Windows VM right now. BTW, would you consider removing the valgrind section from the PR template since Valgrind is known to be unclean on |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Work done as part of #7207 made the in_exec plugin build-able on Windows, but did not enable it as part of the build.
Enable its compliation on Windows per request of @patrick-stephens .
Please also merge related Windows PR #7463
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
master
is totally valgrind-unclean so please remove this from the PR template^^If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.