core: metrics: Provide capabilities for returning the count of hot reloaded in REST API and its metrics #7899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For HTTP REST API users, there is lack of capability to confirm that the status of hot-reloading.
It would be nice to have the endpoint which can handle the request for returning the count of the hot-reloading times.
Also, we need to provide the metrics for the status of hot-reloading counts.
In this PR, I added two capabilities.
One is providing an endpoint which can handle GET method to return the count of hot-reloading.
This can be called with:
$ curl -XGET <hostname>:2020/api/v2/reload
The other is provide a v2 metrics which includes the count of hot-reloading.
This can be called by:
$ curl -XGET <hostname>:2020/api/v2/metrics
Then, the metrics can be displayed as follows:
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
A documentation for newly added endpoint: fluent/fluent-bit-docs#1192
A documentation for v2 endpoint and v2 metrics: fluent/fluent-bit-docs#1193
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.