Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_format: fix memory leak #7961

Merged

Conversation

DavidKorczynski
Copy link
Contributor

There can be multiple states needing to be popped in the event of errors.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61733


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

There can be multiple states needing to be popped in the event of
errors.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=61733

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 22, 2023 20:31 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 22, 2023 20:31 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 22, 2023 20:31 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 22, 2023 20:59 — with GitHub Actions Inactive
@edsiper
Copy link
Member

edsiper commented Sep 23, 2023

not passing CI

@edsiper
Copy link
Member

edsiper commented Sep 23, 2023

cc: @pwhelan

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 05:18 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 05:18 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 05:18 — with GitHub Actions Inactive
@DavidKorczynski
Copy link
Contributor Author

Unit test failing looks unrelated?

@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 05:46 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 10:57 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 10:57 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 10:57 — with GitHub Actions Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 26, 2023 11:24 — with GitHub Actions Inactive
@pwhelan
Copy link
Contributor

pwhelan commented Sep 26, 2023

Unit test failing looks unrelated?

The failure in flb-rt-core_chunk_trace is unrelated, yes. The failure in flb-it-log is simply due to jitter and how strict the test is.

Copy link
Contributor

@pwhelan pwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It works as intended.

The CI tests failed to an unrelated change which should be fixed in master now.

@leonardo-albertovich leonardo-albertovich merged commit 1ca1d02 into fluent:master Sep 26, 2023
60 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants