Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_format: yaml: fix error logic for input processors and cfl_array. #7976

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Sep 26, 2023

Summary

Fix the logic behind handling errors when allocating a cfl_array in the yaml parser for input processors.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@pwhelan pwhelan changed the title Pwhelan fix cf yaml carr alloc config_format: yaml: fix cf yaml carr alloc Sep 26, 2023
@pwhelan pwhelan temporarily deployed to pr September 26, 2023 15:21 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 26, 2023 15:21 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 26, 2023 15:21 — with GitHub Actions Inactive
@pwhelan pwhelan changed the title config_format: yaml: fix cf yaml carr alloc config_format: yaml: fix error logic for input processors and cfl_array. Sep 26, 2023
@pwhelan pwhelan temporarily deployed to pr September 26, 2023 15:55 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 27, 2023 18:12 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 27, 2023 18:12 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 27, 2023 18:12 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr September 27, 2023 18:43 — with GitHub Actions Inactive
@pwhelan pwhelan added this to the Fluent Bit v2.1.11 milestone Sep 27, 2023
@pwhelan pwhelan force-pushed the pwhelan-fix-cf-yaml-carr-alloc branch from e91f989 to 6a95c59 Compare October 12, 2023 21:48
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 21:49 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 21:49 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 21:49 — with GitHub Actions Inactive
@pwhelan pwhelan temporarily deployed to pr October 12, 2023 22:21 — with GitHub Actions Inactive
@edsiper edsiper merged commit a095d9e into master Oct 17, 2023
42 checks passed
@edsiper edsiper deleted the pwhelan-fix-cf-yaml-carr-alloc branch October 17, 2023 14:33
@edsiper
Copy link
Member

edsiper commented Oct 17, 2023

@pwhelan do we need a backport to 2.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants