out_chronicle: remove redundant code #8004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These initializations are redundant. The variables are already initialized with these values and there's no code that could change them until this point. Signed-off-by: lecaros <[email protected]>
To this point, found will always be FLB_FALSE (hence the expression will always be true). It's only changed in one line, and that block ends with a break, hence never reaching the removed if statement. Signed-off-by: lecaros <[email protected]>
If the record is found, a break is issued. If it's not, then it must always log_key_missing++. Signed-off-by: lecaros <[email protected]>
lecaros
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
cosmo0920
approved these changes
Oct 6, 2023
leonardo-albertovich
pushed a commit
that referenced
this pull request
Nov 3, 2023
These initializations are redundant. The variables are already initialized with these values and there's no code that could change them until this point. Signed-off-by: lecaros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant initializations in
fluent-bit/plugins/out_chronicle/chronicle.c
Lines 553 to 555 in 92e0435
The variables are already initialized with these values, and there's no code that could change them until this point.
Remove unnecessary if
fluent-bit/plugins/out_chronicle/chronicle.c
Lines 610 to 612 in 92e0435
At this point,
foundwill always beFLB_FALSE(hence, the expression will always be true).It's only changed in one line, and that block ends with a break
fluent-bit/plugins/out_chronicle/chronicle.c
Line 605 in 92e0435
If the record is found, a break is issued. If it's not, then it must always log_key_missing++.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.