Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_forward: fix checking return value of cmt_decode_msgpack_create(#8000) #8015

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

nokute78
Copy link
Collaborator

@nokute78 nokute78 commented Oct 7, 2023

cmt_encode_msgpack_create can return positive error code like CMT_DECODE_MSGPACK_INVALID_ARGUMENT_ERROR.
We should check if the return value is CMT_DECODE_MSGPACK_SUCCESS or not.

#8000 can be caused if the API returns positive error and cmt is invalid pointer.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@nokute78 nokute78 temporarily deployed to pr October 7, 2023 10:59 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr October 7, 2023 10:59 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr October 7, 2023 10:59 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr October 7, 2023 11:25 — with GitHub Actions Inactive
@edsiper edsiper added this to the Fluent Bit v2.2.0 milestone Oct 17, 2023
@edsiper edsiper merged commit b2072a4 into fluent:master Oct 17, 2023
42 of 44 checks passed
edsiper pushed a commit that referenced this pull request Oct 17, 2023
edsiper pushed a commit that referenced this pull request Oct 19, 2023
edsiper pushed a commit that referenced this pull request Oct 19, 2023
leonardo-albertovich pushed a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants