Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload: add missing flb_cf_destroy #8042

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

nokute78
Copy link
Collaborator

This patch is to add flb_cf_destroy on error case.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Takahiro Yamashita <[email protected]>
@nokute78 nokute78 temporarily deployed to pr October 14, 2023 22:58 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr October 14, 2023 22:59 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr October 14, 2023 22:59 — with GitHub Actions Inactive
@nokute78 nokute78 temporarily deployed to pr October 14, 2023 23:24 — with GitHub Actions Inactive
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@edsiper edsiper added this to the Fluent Bit v2.2.0 milestone Oct 17, 2023
@edsiper
Copy link
Member

edsiper commented Oct 17, 2023

thank you, can you please submit a backport for 2.1 ?

@edsiper edsiper merged commit fe0debf into fluent:master Oct 17, 2023
42 checks passed
@nokute78
Copy link
Collaborator Author

I sent a patch for 2.1.
#8074

@nokute78 nokute78 deleted the release_new_cf branch October 20, 2023 21:38
leonardo-albertovich pushed a commit that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants