reload: bin: filter: handle invalid values of configuration correctly on hot reloading #8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
In our hot-reloading context handling, there is a possibility not to able to handle hot-reloading correctly. For this case, we should treat as error and halt the process. Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
cosmo0920-handle-invalid-values-of-configuration-correctly-on-hot-reloading
branch
from
e31cbdb to
8eb112a
Compare
…er plugins .cb_pre_run should be provided for filter plugins that is easily to get faulty statuses. For now, it's going to be used only for filter_lua. Signed-off-by: Hiroshi Hatake <[email protected]>
…pre_run Signed-off-by: Hiroshi Hatake <[email protected]>
…he file in wasm_path Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
changed the title
edsiper
deleted the
cosmo0920-handle-invalid-values-of-configuration-correctly-on-hot-reloading
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On hot-reloading, we intended to keep fluent-bit process as much as possible when an error is included in the loaded configuration file.
However, the current behavior is not ideal for containing invalid values for provided valid parameters in the configuration file during hot-reloading. This PR is mainly for filter_lua case which is loaded invalid lua script as described in #8067.
In this situation, we should validate malformed values especially for Lua script.
In filter_lua, fluent-bit isn't able to process events when loading an invalid Lua script. This should be halted for hot-reloading process.
Related to #8067
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.