Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk_trace: add wait in test to avoid use after free in lib callback. #8139

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Nov 7, 2023

Summary

This one liner should fix the sporadic CI failures in the `flb-rt-core_chunk_trace' test. The crash occurs when the flb_lib based input uses the records structure after the test has exited and freed them. I added a sleep to avoid this scenario.

At the very least it ran around 725 times in succession without any further errors:

while ./bin/flb-rt-core_chunk_trace > error.log 2>&1 ; do echo -n "." ; done
.....................................................................................
.....................................................................................
.....................................................................................
.....................................................................................
.....................................................................................
.....................................................................................
.....................................................................................
.....................................................................................
.............................................^C

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@edsiper edsiper merged commit fefa093 into master Nov 7, 2023
43 of 45 checks passed
@edsiper edsiper deleted the pwhelan-core-chunk-test-macos branch November 7, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants