Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input: add support for upstream configuration for input client plugins. #8142

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pwhelan
Copy link
Contributor

@pwhelan pwhelan commented Nov 7, 2023

Summary

Add support for upstream configuration for client input plugins.

Description

Client side input plugins like in_health and in_kubernetes_events use the upstream API but the property check for input plugins only applies downstream configuration checks. This pull request checks the plugin flags to see which one applies, either the downstream or upstream configuration map.

Notes

I have not added a check to make sure that not both flags, FLB_INPUT and FLB_INPUT_SERVER, are set on a plugin. In this case the downstream configuration map would be used. There should probably be a check, earlier than flb_input_net_property_check, that actually checks that both flags are not set.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.


Copy link
Contributor

github-actions bot commented Feb 7, 2024

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Feb 7, 2024
@edsiper edsiper added this to the Fluent Bit v3.1.0 milestone Jun 6, 2024
@edsiper
Copy link
Member

edsiper commented Jul 8, 2024

moving it to the next milestone

@edsiper edsiper self-assigned this Jul 8, 2024
@edsiper edsiper removed this from the Fluent Bit v3.1.0 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants