-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add missing shared library linker flags #8168
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Dim-P <[email protected]>
Please fill out the PR template appropriately. |
Are there any instructions on how to setup an environment to run |
It repeats the fluent-bit/packaging/local-build-all.sh Lines 5 to 14 in 281aea0
The container build also covers it: https://github.com/fluent/fluent-bit/tree/master/dockerfiles#multiple-architecture-support |
Is that required for the PR to be approved, given that the CI passes? |
No, we just prefer it to be working prior to spending the compute resources to build it all and verify. |
Anything else required to get this approve? I believe the failing CI test is irrelevant to this PR. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Issue: I noticed that when building the shared library on FreeBSD, it fails to be loaded by any programs attempting to use it via
dlopen()
.Solution: This PR fixes that by adding the necessary linker flags, to link the shared library to
util
. It probably fixes the same issue onarmv7l
, but I have not tested that scenario.Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
[N/A] Example configuration file for the change
[N/A] Debug log output from testing the change
[N/A] Attached Valgrind output that shows no leaks or memory corruption was found
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
[N/A] Run local packaging test showing all targets (including any new ones) build.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
[N/A] Documentation required for this feature
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.