flb_input_chunk: skip overlimit check in mem mode #8199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an output plugin is configured to use `storage.total_limit_size` while the input plugin uses memory storage mode, it would previously continue calculating and eventually pass an empty pointer to the storage context in the function that releases space. This PR adds a validationg in the overlimit route check that will cause the check to be skipped, ensuring that the rest of the space freeing routines are never executed. Signed-off-by: Braydon Kains <[email protected]>
braydonk
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
This commit uses a different implementation than the previous; instead of checking in each output plugin and logging, this will just skip the check entirely when not in FS mode. The downside is that there is no log indicating that the memory plugin is going to an output with `storage.total_limit_size` where it has no effect, but this is a reasonable expectation to configure for so that would just be adding extra work just to be able to do some debug logging. Signed-off-by: Braydon Kains <[email protected]>
braydonk
changed the title
|
This issue is causing segfaults predictably once the configured |
|
thanks for the contribution. note: commit subject must start with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an output plugin is configured to use
storage.total_limit_sizewhile the input plugin uses memory storage mode, it would previouslycontinue calculating and eventually pass an empty pointer to the
storage context in the function that releases space. This PR adds a
validationg in the overlimit route check that will cause the check to
be skipped, ensuring that the rest of the space freeing routines are
never executed.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Any input plugin with memory storage type, any output plugin with
storage.total_limit_sizeset. I tested it with this:If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Maybe, I did not look into when this bug was introduced. May have been nascent for a long time.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.