-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_stackdriver: add k8s_cluster resource type #8349
out_stackdriver: add k8s_cluster resource type #8349
Conversation
test failure looks like a flake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good to me!
Would you mind adding a test for this as well? You can use this other resource test as a reference. I can intuitively see that this will work based on the implementation, so it's just a matter of getting a test for it.
I'll be good to merge it after a test is added!
this can be used in combination with the in_kubernetes_events to write k8s_cluster type events to stackdriver(such as replicaset events) Signed-off-by: ryanohnemus <[email protected]>
Signed-off-by: ryanohnemus <[email protected]>
180bd3c
to
a1cf43e
Compare
@braydonk, just rebased and pushed with a test. I will watch the CI checks for any failures, but otherwise we should be good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, unless something in CI fails I will merge.
* out_stackdriver: add k8s_cluster resource type this can be used in combination with the in_kubernetes_events to write k8s_cluster type events to stackdriver(such as replicaset events) Signed-off-by: ryanohnemus <[email protected]> * out_stackdriver: add k8s_cluster resource test Signed-off-by: ryanohnemus <[email protected]> --------- Signed-off-by: ryanohnemus <[email protected]>
Add k8s_cluster resource type to out_stackdriver plugin.
This can be used in combination with the in_kubernetes_events to write k8s_cluster type events to stackdriver (such as any non-Pod based kubernetes events)
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
out_stackdriver: add k8s_cluster resource type fluent-bit-docs#1284
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.