Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: wasm: upgrade wasm-micro-runtime to WAMR-1.3.2 #8744

Closed

Conversation

ThomasDevoogdt
Copy link
Contributor

@ThomasDevoogdt ThomasDevoogdt commented Apr 20, 2024

Main reason for the bump:

  • Enhance setting write gs base with cmake variable (#3066) --> fixes cross compilation on buildroot

Other news:

@ThomasDevoogdt ThomasDevoogdt changed the title lib: Upgrade wasm-micro-runtime to v1.3.2 build: wasm: upgrade wasm-micro-runtime to WAMR-1.3.2 Apr 20, 2024
@ThomasDevoogdt ThomasDevoogdt force-pushed the feature/bump-wamr-1.3.2 branch from 7fa28f3 to bf5d45f Compare April 20, 2024 16:12
@ThomasDevoogdt ThomasDevoogdt force-pushed the feature/bump-wamr-1.3.2 branch from bf5d45f to 5f28ac7 Compare April 20, 2024 16:14
@patrick-stephens
Copy link
Contributor

HadoLint is failing because this PR is too large...
However it does not touch the container definition so can be safely ignored.

@ThomasDevoogdt
Copy link
Contributor Author

@edsiper @cosmo0920 @patrick-stephens @leonardo-albertovich Hi, I rebased this PR to the current master. Is it possible to consider this PR?

@ThomasDevoogdt
Copy link
Contributor Author

Hi @cosmo0920, is it possible to also add a "Fluent Bit v3.2.0" tag for this PR? Or to just merge it?

Main reason for the bump:

Enhance setting write gs base with cmake variable (bytecodealliance/wasm-micro-runtime#3066)
 --> fixes cross compilation on buildroot

Other news:
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.1
 - https://github.com/bytecodealliance/wasm-micro-runtime/releases/tag/WAMR-1.3.2

Signed-off-by: Thomas Devoogdt <[email protected]>
@patrick-stephens
Copy link
Contributor

I think best to leave this with @cosmo0920 for review.

@edsiper
Copy link
Member

edsiper commented Dec 5, 2024

closing in favor of #9643

@edsiper edsiper closed this Dec 5, 2024
@ThomasDevoogdt
Copy link
Contributor Author

closing in favor of #9643

Thanks!

@ThomasDevoogdt ThomasDevoogdt deleted the feature/bump-wamr-1.3.2 branch December 15, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants