Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: macos: Use matrix for building Apple Silicon artefacts #8765

Merged

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Apr 26, 2024

GitHub now published hosted runners which are based on M1 macOS: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

To use them and continue to use Intel mac runners, we need to specify them with build matrix and set up with macos-12 and macos-14. Now, macos-latest is pointed in macos-14. So, we need to specify macos-12 or macos-13 explicitly to create Intel Mac artefacts.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 added the ok-package-test Run PR packaging tests label Apr 26, 2024
@cosmo0920 cosmo0920 force-pushed the cosmo0920-use-build-matrix-for-arm64-macos branch 6 times, most recently from 38bef25 to 7853fc7 Compare April 26, 2024 09:20
@cosmo0920 cosmo0920 force-pushed the cosmo0920-use-build-matrix-for-arm64-macos branch from 7853fc7 to 66ef8b4 Compare April 26, 2024 09:22
@cosmo0920 cosmo0920 marked this pull request as ready for review April 26, 2024 09:30
@cosmo0920 cosmo0920 changed the title workkflows: macos: Use matrix for Apple Silicon artefacts workkflows: macos: Use matrix for building Apple Silicon artefacts Apr 26, 2024
@patrick-stephens patrick-stephens merged commit 07475e7 into master May 2, 2024
101 of 102 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-use-build-matrix-for-arm64-macos branch May 2, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants