Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: add build support for ubuntu 24.04 noble numbat #8796

Merged
merged 1 commit into from
May 24, 2024

Conversation

markuman
Copy link
Contributor

@markuman markuman commented May 6, 2024

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Closes: #8775

@markuman
Copy link
Contributor Author

markuman commented May 6, 2024

Run local packaging test showing all targets (including any new ones) build.

This failed in the master branch already for me.

Unable to find /home/m/git/fluent-bit/packaging/distros/{"target":"amazonlinux/Dockerfile

@patrick-stephens

@patrick-stephens
Copy link
Contributor

Run local packaging test showing all targets (including any new ones) build.

This failed in the master branch already for me.

Unable to find /home/m/git/fluent-bit/packaging/distros/{"target":"amazonlinux/Dockerfile

@patrick-stephens

Please fix it up if you can, it may be a shell issue.

@patrick-stephens patrick-stephens added the ok-package-test Run PR packaging tests label May 7, 2024
@patrick-stephens
Copy link
Contributor

@markuman looks like it build for 24.04 - can you test the artefacts downloadable from here? https://github.com/fluent/fluent-bit/actions/runs/8983659311?pr=8796

@patrick-stephens
Copy link
Contributor

Also can you sort the DCO as that's required before we can merge

@markuman markuman force-pushed the 8775-ubuntu-noble branch from 5ef80ec to 93afc5c Compare May 7, 2024 13:12
@markuman
Copy link
Contributor Author

markuman commented May 7, 2024

Also can you sort the DCO as that's required before we can merge

Ok, done (I guess).

@lecaros
Copy link
Contributor

lecaros commented May 11, 2024

hi @markuman,
DCO is fine. You just need to fix the commit message :)
https://github.com/fluent/fluent-bit/actions/runs/8986029386/job/24681695679?pr=8796

@markuman markuman force-pushed the 8775-ubuntu-noble branch from 93afc5c to c06458a Compare May 13, 2024 07:05
@markuman
Copy link
Contributor Author

hi @markuman, DCO is fine. You just need to fix the commit message :) https://github.com/fluent/fluent-bit/actions/runs/8986029386/job/24681695679?pr=8796

Also done (I hope so).

@danybmx
Copy link

danybmx commented May 22, 2024

Hi! Anything I can do to move this forward? 🙇

@patrick-stephens patrick-stephens changed the title add build support for ubuntu 24.04 noble numbat packaging: add build support for ubuntu 24.04 noble numbat May 24, 2024
@patrick-stephens
Copy link
Contributor

The PR title was incorrect so I've updated that.

@patrick-stephens patrick-stephens merged commit bf1a7e5 into fluent:master May 24, 2024
51 of 53 checks passed
@patrick-stephens
Copy link
Contributor

@markuman / @danybmx could you submit a docs PR to add this to the supported targets?

@markuman
Copy link
Contributor Author

@markuman / @danybmx could you submit a docs PR to add this to the supported targets?

Something like that? #8889

@patrick-stephens
Copy link
Contributor

Ah sorry, that's good but also to the actual docs over in the fluent-bit-docs repo

markuman added a commit to markuman/fluent-bit that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Ubuntu 24.04
4 participants