filter_sampling: throttle sampling #8833
Open
+305
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Whelan <[email protected]>
pwhelan
requested review from
fujimotos,
niedbalski,
patrick-stephens,
celalettin1286,
edsiper,
leonardo-albertovich and
koleini
as code owners
pwhelan
changed the title
pwhelan
force-pushed
the
pwhelan-throttle-sampling
branch
from
d2192bb to
9ea7217
Compare
… records. This filter can sample either by using a random number or by using a comb-like filter that will emit X records for each Y steps based on a fraction derived from the rate. Signed-off-by: Phillip Whelan <[email protected]>
pwhelan
force-pushed
the
pwhelan-throttle-sampling
branch
from
9ea7217 to
6f0d976
Compare
…port. Signed-off-by: Phillip Adair Stewart Whelan <[email protected]>
pwhelan
changed the title
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new filter that allows through only a set fraction of records, also referred to as sampling.
This plugin implements two methods of applying said sampling:
The random chance mode simply compares the random number against the percentage of records to decide if a record will be dropped. Over a long enough period of time this should achieve the desired level of filtering.
The comb filter mode calculate a numerator and a denominator that closely represents the fraction of records to filter and then uses a simple state to filter records as it iterates through records.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.