Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: Enable built-in LuaJIT for s390x #8903

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

lib: Enable built-in LuaJIT for s390x #8903

wants to merge 2 commits into from
+6,710 −5

Conversation

rightblank
Copy link

This PR will build luajit for s390x

Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@rightblank rightblank force-pushed the lua_s390x_support branch from 865d63a to 0ae1cfc Compare June 2, 2024 12:18
cosmo0920
cosmo0920 requested changes Jun 3, 2024
View reviewed changes
cmake/s390x.cmake Outdated Show resolved Hide resolved
@patrick-stephens patrick-stephens added the ok-package-test Run PR packaging tests label Jun 3, 2024
@rightblank rightblank changed the title in_lua: Enable luajit for s390x filter_lua: Enable luajit for s390x Jun 6, 2024
@rightblank rightblank requested a review from cosmo0920 June 7, 2024 03:49
@cosmo0920
Copy link
Contributor

Just for my curiosity, how could we test this PR on s390x? Using IBM cloud is necessary to compile and run?

@cosmo0920
Copy link
Contributor

cosmo0920 commented Jun 7, 2024 •
edited
Loading

Plus, without merging s390x patches for LuaJIT on upstream makes difficult to maintain further updates.
In short, we'll need to update with this patch every time we wanted to import further updates on LuaJIT.
Within this PR, I'm not against to include this change but maintaining perspective, I'm still against to merge this.

@edsiper
Copy link
Member

edsiper commented Jun 7, 2024

would be great to have these changes in https://github.com/LuaJIT/LuaJIT , as @cosmo0920 said we cannot maintain LuaJIT

@rightblank
Copy link
Author

rightblank commented Jun 11, 2024 •
edited
Loading

Hi, @cosmo0920 @edsiper,

  • @iii-i is actively maintaing LuaJIT support for s390x in s390x support LuaJIT/LuaJIT#631 quite actively on the basis of LuaJIT:v2.1.
  • For fluent-bit, we just have to copy the LuaJIT code from @iii-i's branch.
  • Moreover, SUSE has this patch in their enterprise products and it's being tested on open SUSE continuously as pointed out in the comment of that PR.
  • Lastly, the maintainer is not responding to the PR in the last 4 years and it might gonna be like this for a long time, but merging this PR will improve the general availability for fluent bit on s390x to a new level.

@rightblank
Copy link
Author

Just for my curiosity, how could we test this PR on s390x? Using IBM cloud is necessary to compile and run?

Hi, @cosmo0920, you can use the LinuxONE Community Cloud. The usage is free for Open-Source Developers:
https://developer.ibm.com/components/ibm-linuxone/gettingstarted/

@cosmo0920
Copy link
Contributor

cosmo0920 commented Jun 11, 2024 •
edited
Loading

  • Lastly, the maintainer is not responding to the PR in the last 4 years and it might gonna be like this for a long time, but merging this PR will improve the general availability for fluent bit to a new level.

I searched why the maintainer does not respond for 4 years. And I found that he is mainly responded in the mailing list of LuaJIT:
https://www.freelists.org/archive/luajit/

However, the plan is not included s390x architecture: https://luajit.org/status.html#architectures
And the tracking issue for s390x: LuaJIT/LuaJIT#43

Merging this PR dramatically increases maintenance cost for us. So, I'm not able to agree for this style of request.
We love to import upstream changes with few changes. So, this PR is not followed our style of importing dependent libraries.

@cosmo0920
Copy link
Contributor

cosmo0920 commented Jun 11, 2024 •
edited
Loading

Or, I'm not sure the packaging system on s390x, but #7286 might be helpful to link s390x supported LuaJIT libraries. If we had this support, your issue will be resolved? WDYT?

@rightblank
Copy link
Author

Or, I'm not sure the packaging system on s390x, but #7286 might be helpful to link s390x supported LuaJIT libraries. If we had this support, your issue will be resolved? WDYT?

I will try #7286 out locally first!

@rightblank
Copy link
Author

Or, I'm not sure the packaging system on s390x, but #7286 might be helpful to link s390x supported LuaJIT libraries. If we had this support, your issue will be resolved? WDYT?

Hi, @cosmo0920 , I have tried #7286 on s390x and it works, please help to merge it and I will close this PR here.

@rightblank rightblank mentioned this pull request Jul 3, 2024
Merged
2 tasks
YingJie Fu added 2 commits July 17, 2024 20:41
@rightblank rightblank changed the title filter_lua: Enable luajit for s390x lib: Enable built-in LuaJIT for s390x Jul 18, 2024
@rightblank
Copy link
Author

Resolved the code conflicts.

@rightblank
Copy link
Author

Hi, @edsiper , what's your opinion on this PR and #7286? Would you please get at least one of them merged so LuaJIT can be used on s390x? Thanks!

@github-actions GitHub Actions
Copy link
Contributor

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujimotos fujimotos Awaiting requested review from fujimotos fujimotos is a code owner

@niedbalski niedbalski Awaiting requested review from niedbalski niedbalski is a code owner

@patrick-stephens patrick-stephens Awaiting requested review from patrick-stephens patrick-stephens is a code owner

@celalettin1286 celalettin1286 Awaiting requested review from celalettin1286 celalettin1286 is a code owner

@edsiper edsiper Awaiting requested review from edsiper edsiper is a code owner

@leonardo-albertovich leonardo-albertovich Awaiting requested review from leonardo-albertovich leonardo-albertovich is a code owner

@koleini koleini Awaiting requested review from koleini koleini is a code owner

@cosmo0920 cosmo0920 Awaiting requested review from cosmo0920

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
docs-required ok-package-test Run PR packaging tests Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rightblank @cosmo0920 @edsiper @patrick-stephens