Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

out_cloudwatch_logs: fix disabled auto_create_group #9114

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

sjoerdsmink
Copy link
Contributor

Fixes #8949

Since release 3.0.7 auto_create_group couldn't be set to Off anymore. That was a breaking change.

I didn't see any reason why log_group_class_type and log_group_class should be set, as they're not used when [auto_]create_group is off.

Please review @PettitWesley @edsiper


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@edsiper edsiper added this to the Fluent Bit v3.1.4 milestone Jul 24, 2024
@sjoerdsmink sjoerdsmink changed the title Fix disabling CloudWatch Logs auto_create_group out_cloudwatch_logs: fix disabled auto_create_group Jul 25, 2024
@cschp
Copy link

cschp commented Jul 31, 2024

hoping to see this tested and merged soon

@edsiper
Copy link
Member

edsiper commented Aug 14, 2024

LGTM

@edsiper edsiper merged commit f6906f9 into fluent:master Aug 14, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

out_cloudwatch_logs: log_group_class option introduced breaking change in 3.0.7
3 participants