-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out_prometheus_exporter: Handle multiply concatenated metrics type of events #9122
out_prometheus_exporter: Handle multiply concatenated metrics type of events #9122
Conversation
… events Signed-off-by: Hiroshi Hatake <[email protected]>
82a222f
to
d34a9e7
Compare
I am wondering if this logic should be handled inside cmetrics in the prometheus encoder... |
I don't think so. Because decoding msgpack should be placed in the msgpack decoder in cmetrics. And, it should be processing with offsets. Current implementation is only processing until reaching the first offset in msgpack decoder. |
FYI: out_prometheus_remote_write plugin uses similar pattern to decode multiply concatenated cmetrics context: https://github.com/fluent/fluent-bit/blob/master/plugins/out_prometheus_remote_write/remote_write.c#L319 |
Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
note: when submitting, please rework the commits to have a clean history |
Like as ctraces, there is a possibility to handle concatenated metrics type of events payloads during processing #9119.
This is because in_statsd of metrics ingestion mode requests to handle cmetrics payloads which is ingested events more one times per a cycle.
Currently, we need to handle manually for multiply concatenated cmetrics payloads to handle multiple ingestion for metrics type of events.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.