-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_util: fix leading zeros in time_key strings #9128
Merged
edsiper
merged 1 commit into
fluent:master
from
kangaechu:fix-leading-zeros-in-aws-util-time_key-strings
Aug 7, 2024
Merged
aws_util: fix leading zeros in time_key strings #9128
edsiper
merged 1 commit into
fluent:master
from
kangaechu:fix-leading-zeros-in-aws-util-time_key-strings
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangaechu
force-pushed
the
fix-leading-zeros-in-aws-util-time_key-strings
branch
from
July 25, 2024 01:31
e27cbbb
to
ef78b47
Compare
kangaechu
force-pushed
the
fix-leading-zeros-in-aws-util-time_key-strings
branch
from
July 25, 2024 02:52
ef78b47
to
8e75e18
Compare
Signed-off-by: kangaechu <[email protected]>
kangaechu
force-pushed
the
fix-leading-zeros-in-aws-util-time_key-strings
branch
from
July 25, 2024 03:16
8e75e18
to
330114f
Compare
@PettitWesley Would you review this PR? |
@edsiper Would you review this PR? |
leonardo-albertovich
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the documentation this change is correct.
thank you |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes leading zeros in time_key strings.
The kinesis_datastream/kinesis_firehose ouput plugin can add timestamps by specifying the time_key/time_key_format parameters.
Format qualifiers include
%3N
for milliseconds and%9N
/%L
for nanoseconds.In the current implementation, the number of digits in the timestamp is insufficient when milliseconds are smaller than 100 ms (e.g.,
0xx
/00x
) or nanoseconds are smaller than 100 ms (e.g.,0xxxxxxxxxxx
/00xxxxxxxxx
).Therefore, the number of digits has been corrected to be correct.
This fix was opened by @PettitWesley in #8116, but there have been no changes for about 6 months, and I was troubled that this problem was not resolved.
Therefore, I created a new Pull request.
Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.