-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in_kubernetes_events: fix k8s events end of stream deadlock #9154
Merged
edsiper
merged 2 commits into
fluent:master
from
ryanohnemus:in_k8s_events_end_of_stream
Aug 2, 2024
Merged
in_kubernetes_events: fix k8s events end of stream deadlock #9154
edsiper
merged 2 commits into
fluent:master
from
ryanohnemus:in_k8s_events_end_of_stream
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryanohnemus <[email protected]>
ryanohnemus
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
August 1, 2024 19:00
ryanohnemus
force-pushed
the
in_k8s_events_end_of_stream
branch
from
August 1, 2024 19:36
73e2dc2
to
aa61aed
Compare
ryanohnemus
force-pushed
the
in_k8s_events_end_of_stream
branch
from
August 1, 2024 21:32
aa61aed
to
feb92e4
Compare
Signed-off-by: ryanohnemus <[email protected]>
ryanohnemus
force-pushed
the
in_k8s_events_end_of_stream
branch
from
August 1, 2024 22:22
feb92e4
to
837828e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The http client connection used to watch (stream) k8s events from the kube api server could deadlock the kubernetes_events plugin if the k8s api server ends the connection with a standard end of chunked stream instead of a different connection closure that would result in the http client returning an FLB_HTTP_ERROR. This same deadlock can also occur if there is a http client connection initialization error.
In either scenario the ctx->streaming_client and ctx->current_connection do not get cleaned up, which results in the next coro being deadlocked because we did not unlock
pthread_mutex_unlock(&ctx->lock);
(after obtaining the lock and checking if the streaming_client already exists.)Enter
[N/A]
in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.