workflows: add sanity check for toolchains w/ CXX support #9277
Conversation
ThomasDevoogdt
requested review from
niedbalski,
patrick-stephens,
celalettin1286,
fujimotos,
edsiper,
leonardo-albertovich and
koleini
as code owners
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
from
06b1ed2 to
7cb18ea
Compare
ThomasDevoogdt
changed the title
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
3 times, most recently
from
ddf2522 to
a3c1402
Compare
|
Hi, we don't want to modify the vendored libraries by ourselves. |
Understand that, see my other PR/ remark #7765 (comment). There is an upstream PR: confluentinc/librdkafka#4366, but no reply in over a year. |
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
from
a3c1402 to
d734a74
Compare
|
Hi @cosmo0920, is it possible to re-evaluate this? I don't get an answer from upstream, but the changes are relevant IMHO. So I think that we should go forward with it. I know that changes exists that this issue wrt librdkafka gets re-introduced when syncing upstream, but the added workflows will tell us about this at that time. |
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
from
d734a74 to
6c93936
Compare
…fluent#7741 e.g. fluent-bit is a c-only library, so allow compilation without cxx Upstream: confluentinc/librdkafka#4366 Signed-off-by: Thomas Devoogdt <[email protected]>
Fluent-bit is c only, so no need to compile cxx. This fixes also a compile error in buildroot. Signed-off-by: Thomas Devoogdt <[email protected]>
Upstream: nghttp2/nghttp2@d9d2661 Signed-off-by: Thomas Devoogdt <[email protected]>
Signed-off-by: Thomas Devoogdt <[email protected]>
Fluent-bit is written in C, so don't require CXX, also not from the libs. Signed-off-by: Thomas Devoogdt <[email protected]>
ThomasDevoogdt
force-pushed
the
feature/enforce-no-cxx-support
branch
from
6c93936 to
539bf0a
Compare
|
@edsiper It has been a while. Any chance that this gets approved? I try to reduce my own patch list. |
Fluent-bit is written in C. There is no reason to have a CXX compiler. (Except for some libs which are all individually optional.) So add a check that enforces a C-only toolchain. E.g. useful for buildroot which does support platforms with only a C compiler.
This PR is WIP, I otherwise don't have a way to test the GitHub actions.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.