Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_winevtlog: Use correct flag for EvtRender #9659

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

mkfrey
Copy link
Contributor

@mkfrey mkfrey commented Nov 28, 2024

Fix the flags argument of one of the calls to EvtRender. It's currently using a value of the EVT_RENDER_CONTEXT_FLAGS enum, which contains flags for creating the render context. This commit replaces it with the correct flag of the enum EVT_RENDER_FLAGS, which is also used on the prior call to determine the buffer size.

Since both enum values are 0, this minor mistake is unlikely to have caused any issues.


Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for your confirmation and fixing.

@cosmo0920 cosmo0920 added this to the Fluent Bit Next milestone Nov 29, 2024
@edsiper edsiper merged commit dd6322c into fluent:master Dec 5, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants